Skip to content

Commit 44a89e5

Browse files
committed
remove redundant telemetryService variable
1 parent ae617b7 commit 44a89e5

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/vs/platform/extensionManagement/test/common/extensionGalleryService.test.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import product from 'vs/platform/product/common/product';
2121
import { IProductService } from 'vs/platform/product/common/productService';
2222
import { resolveMarketplaceHeaders } from 'vs/platform/externalServices/common/marketplace';
2323
import { InMemoryStorageService, IStorageService } from 'vs/platform/storage/common/storage';
24-
import { ITelemetryService, TelemetryConfiguration, TELEMETRY_SETTING_ID } from 'vs/platform/telemetry/common/telemetry';
24+
import { TelemetryConfiguration, TELEMETRY_SETTING_ID } from 'vs/platform/telemetry/common/telemetry';
2525
import { TargetPlatform } from 'vs/platform/extensions/common/extensions';
2626
import { NullTelemetryService } from 'vs/platform/telemetry/common/telemetryUtils';
2727

@@ -37,7 +37,6 @@ class EnvironmentServiceMock extends mock<IEnvironmentService>() {
3737
suite('Extension Gallery Service', () => {
3838
const disposables: DisposableStore = new DisposableStore();
3939
let fileService: IFileService, environmentService: IEnvironmentService, storageService: IStorageService, productService: IProductService, configurationService: IConfigurationService;
40-
let telemetryService: ITelemetryService;
4140

4241
setup(() => {
4342
const serviceMachineIdResource = joinPath(URI.file('tests').with({ scheme: 'vscode-tests' }), 'machineid');
@@ -49,15 +48,14 @@ suite('Extension Gallery Service', () => {
4948
configurationService = new TestConfigurationService({ [TELEMETRY_SETTING_ID]: TelemetryConfiguration.ON });
5049
configurationService.updateValue(TELEMETRY_SETTING_ID, TelemetryConfiguration.ON);
5150
productService = { _serviceBrand: undefined, ...product, enableTelemetry: true };
52-
telemetryService = NullTelemetryService;
5351
});
5452

5553
teardown(() => disposables.clear());
5654

5755
test('marketplace machine id', async () => {
58-
const headers = await resolveMarketplaceHeaders(product.version, productService, environmentService, configurationService, fileService, storageService, telemetryService);
56+
const headers = await resolveMarketplaceHeaders(product.version, productService, environmentService, configurationService, fileService, storageService, NullTelemetryService);
5957
assert.ok(isUUID(headers['X-Market-User-Id']));
60-
const headers2 = await resolveMarketplaceHeaders(product.version, productService, environmentService, configurationService, fileService, storageService, telemetryService);
58+
const headers2 = await resolveMarketplaceHeaders(product.version, productService, environmentService, configurationService, fileService, storageService, NullTelemetryService);
6159
assert.strictEqual(headers['X-Market-User-Id'], headers2['X-Market-User-Id']);
6260
});
6361

0 commit comments

Comments
 (0)