use onTerminalShellIntegration for terminal suggest activation (microsoft#252329)

Author: meganrogge

extensions/terminal-suggest/package.json

@@ -25,7 +25,7 @@
   },
   "main": "./out/terminalSuggestMain",
   "activationEvents": [
-    "onTerminalCompletionsRequested"
+    "onTerminalShellIntegration:*"
   ],
   "repository": {
     "type": "git",

src/vs/workbench/api/browser/mainThreadTerminalShellIntegration.ts

@@ -11,6 +11,7 @@ import { ITerminalService, type ITerminalInstance } from '../../contrib/terminal
 import { IWorkbenchEnvironmentService } from '../../services/environment/common/environmentService.js';
 import { extHostNamedCustomer, type IExtHostContext } from '../../services/extensions/common/extHostCustomers.js';
 import { TerminalShellExecutionCommandLineConfidence } from '../common/extHostTypes.js';
+import { IExtensionService } from '../../services/extensions/common/extensions.js';
 
 @extHostNamedCustomer(MainContext.MainThreadTerminalShellIntegration)
 export class MainThreadTerminalShellIntegration extends Disposable implements MainThreadTerminalShellIntegrationShape {
@@ -19,7 +20,8 @@ export class MainThreadTerminalShellIntegration extends Disposable implements Ma
 	constructor(
 		extHostContext: IExtHostContext,
 		@ITerminalService private readonly _terminalService: ITerminalService,
-		@IWorkbenchEnvironmentService workbenchEnvironmentService: IWorkbenchEnvironmentService
+		@IWorkbenchEnvironmentService workbenchEnvironmentService: IWorkbenchEnvironmentService,
+		@IExtensionService private readonly _extensionService: IExtensionService
 	) {
 		super();
 
@@ -111,6 +113,11 @@ export class MainThreadTerminalShellIntegration extends Disposable implements Ma
 	}
 
 	private _enableShellIntegration(instance: ITerminalInstance): void {
+		this._extensionService.activateByEvent('onTerminalShellIntegration:*');
+		this._register(instance.onDidChangeShellType(() => this._extensionService.activateByEvent(`onTerminalShellIntegration:${instance.shellType}`)));
+		if (instance.shellType) {
+			this._extensionService.activateByEvent(`onTerminalShellIntegration:${instance.shellType}`);
+		}
 		this._proxy.$shellIntegrationChange(instance.instanceId);
 		const cwdDetection = instance.capabilities.get(TerminalCapability.CwdDetection);
 		if (cwdDetection) {

src/vs/workbench/services/extensions/common/extensionsRegistry.ts

@@ -403,6 +403,11 @@ export const schema: IJSONSchema = {
 						body: 'onTerminalCompletionsRequested',
 						description: nls.localize('vscode.extension.activationEvents.onTerminalCompletionsRequested', 'An activation event emitted when terminal completions are requested.'),
 					},
+					{
+						label: 'onTerminalShellIntegration',
+						body: 'onTerminalShellIntegration:${1:shellType}',
+						description: nls.localize('vscode.extension.activationEvents.onTerminalShellIntegration', 'An activation event emitted when terminal shell integration is activated for the given shell type.'),
+					},
 					{
 						label: 'onMcpCollection',
 						description: nls.localize('vscode.extension.activationEvents.onMcpCollection', 'An activation event emitted whenver a tool from the MCP server is requested.'),