fix: unexpected error when execCommand workbench.extensions.installExtension (microsoft#210135)

zWingz · web-flow · commit 49c1a3ee9551 · 2024-04-11T16:33:53.000+02:00
fix: microsoft#210129
diff --git a/src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts b/src/vs/workbench/contrib/extensions/browser/extensions.contribution.ts
@@ -358,7 +358,7 @@ CommandsRegistry.registerCommand({
 				const extension = extensionsWorkbenchService.local.find(e => areSameExtensions(e.identifier, { id, uuid: version }));
 				if (extension?.enablementState === EnablementState.DisabledByExtensionKind) {
 					const [gallery] = await extensionGalleryService.getExtensions([{ id, preRelease: options?.installPreReleaseVersion }], CancellationToken.None);
-					if (gallery) {
+					if (!gallery) {
 						throw new Error(localize('notFound', "Extension '{0}' not found.", arg));
 					}
 					await extensionManagementService.installFromGallery(gallery, {

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,7 @@ CommandsRegistry.registerCommand({`
`358`	`358`	`const extension = extensionsWorkbenchService.local.find(e => areSameExtensions(e.identifier, { id, uuid: version }));`
`359`	`359`	`if (extension?.enablementState === EnablementState.DisabledByExtensionKind) {`
`360`	`360`	`const [gallery] = await extensionGalleryService.getExtensions([{ id, preRelease: options?.installPreReleaseVersion }], CancellationToken.None);`
`361`		`- if (gallery) {`
	`361`	`+ if (!gallery) {`
`362`	`362`	`throw new Error(localize('notFound', "Extension '{0}' not found.", arg));`
`363`	`363`	`}`
`364`	`364`	`await extensionManagementService.installFromGallery(gallery, {`