Skip to content

Commit 4c06e3f

Browse files
authored
rename proposal from chatRequestAccess to languageModels, move into new lm namespace (microsoft#205272)
* rename proposal from `chatRequestAccess` to `languageModels`, move into new `lm` namespace microsoft#199908 * fix itests
1 parent 633992c commit 4c06e3f

File tree

4 files changed

+24
-17
lines changed

4 files changed

+24
-17
lines changed

extensions/vscode-api-tests/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"activeComment",
99
"authSession",
1010
"chatAgents2",
11-
"chatRequestAccess",
11+
"languageModels",
1212
"defaultChatAgent",
1313
"contribViewsRemote",
1414
"contribStatusBarItems",

src/vs/workbench/api/common/extHost.api.impl.ts

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1395,24 +1395,12 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
13951395
}
13961396
};
13971397

1398-
// namespace: llm
1398+
// namespace: chat
13991399
const chat: typeof vscode.chat = {
14001400
registerChatResponseProvider(id: string, provider: vscode.ChatResponseProvider, metadata: vscode.ChatResponseProviderMetadata) {
14011401
checkProposedApiEnabled(extension, 'chatProvider');
14021402
return extHostChatProvider.registerLanguageModel(extension, id, provider, metadata);
14031403
},
1404-
requestLanguageModelAccess(id, options) {
1405-
checkProposedApiEnabled(extension, 'chatRequestAccess');
1406-
return extHostChatProvider.requestLanguageModelAccess(extension, id, options);
1407-
},
1408-
get languageModels() {
1409-
checkProposedApiEnabled(extension, 'chatRequestAccess');
1410-
return extHostChatProvider.getLanguageModelIds();
1411-
},
1412-
onDidChangeLanguageModels: (listener, thisArgs?, disposables?) => {
1413-
checkProposedApiEnabled(extension, 'chatRequestAccess');
1414-
return extHostChatProvider.onDidChangeProviders(listener, thisArgs, disposables);
1415-
},
14161404
registerVariable(name: string, description: string, resolver: vscode.ChatVariableResolver) {
14171405
checkProposedApiEnabled(extension, 'chatAgents2');
14181406
return extHostChatVariables.registerVariableResolver(extension, name, description, resolver);
@@ -1427,6 +1415,22 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
14271415
},
14281416
};
14291417

1418+
// namespace: lm
1419+
const lm: typeof vscode.lm = {
1420+
requestLanguageModelAccess(id, options) {
1421+
checkProposedApiEnabled(extension, 'languageModels');
1422+
return extHostChatProvider.requestLanguageModelAccess(extension, id, options);
1423+
},
1424+
get languageModels() {
1425+
checkProposedApiEnabled(extension, 'languageModels');
1426+
return extHostChatProvider.getLanguageModelIds();
1427+
},
1428+
onDidChangeLanguageModels: (listener, thisArgs?, disposables?) => {
1429+
checkProposedApiEnabled(extension, 'languageModels');
1430+
return extHostChatProvider.onDidChangeProviders(listener, thisArgs, disposables);
1431+
}
1432+
};
1433+
14301434
// namespace: speech
14311435
const speech: typeof vscode.speech = {
14321436
registerSpeechProvider(id: string, provider: vscode.SpeechProvider) {
@@ -1449,6 +1453,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
14491453
interactive,
14501454
l10n,
14511455
languages,
1456+
lm,
14521457
notebooks,
14531458
scm,
14541459
speech,

src/vs/workbench/services/extensions/common/extensionsApiProposals.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export const allApiProposals = Object.freeze({
1414
chatAgents2: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.chatAgents2.d.ts',
1515
chatAgents2Additions: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.chatAgents2Additions.d.ts',
1616
chatProvider: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.chatProvider.d.ts',
17-
chatRequestAccess: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.chatRequestAccess.d.ts',
1817
chatTab: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.chatTab.d.ts',
1918
codeActionAI: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.codeActionAI.d.ts',
2019
codeActionRanges: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.codeActionRanges.d.ts',
@@ -66,6 +65,7 @@ export const allApiProposals = Object.freeze({
6665
interactive: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.interactive.d.ts',
6766
interactiveWindow: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.interactiveWindow.d.ts',
6867
ipc: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.ipc.d.ts',
68+
languageModels: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.languageModels.d.ts',
6969
languageStatusText: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.languageStatusText.d.ts',
7070
mappedEditsProvider: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.mappedEditsProvider.d.ts',
7171
multiDocumentHighlightProvider: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.multiDocumentHighlightProvider.d.ts',

src/vscode-dts/vscode.proposed.chatRequestAccess.d.ts renamed to src/vscode-dts/vscode.proposed.languageModels.d.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,10 @@ declare module 'vscode' {
152152
readonly removed: readonly string[];
153153
}
154154

155-
//@API DEFINE the namespace for this: lm (languageModels), copilot, ai, env,?
156-
export namespace chat {
155+
/**
156+
* Namespace for language model related functionality.
157+
*/
158+
export namespace lm {
157159

158160
/**
159161
* Request access to a language model.

0 commit comments

Comments
 (0)