Skip to content

Commit 4d42fcf

Browse files
committed
use status instead of alert
1 parent 08eab96 commit 4d42fcf

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

src/vs/base/browser/ui/aria/aria.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import * as dom from 'vs/base/browser/dom';
7-
import { isMacintosh } from 'vs/base/common/platform';
87
import 'vs/css!./aria';
98

109
// Use a max length since we are inserting the whole msg in the DOM and that can cause browsers to freeze for long messages #94233
@@ -69,16 +68,12 @@ export function status(msg: string): void {
6968
return;
7069
}
7170

72-
if (isMacintosh) {
73-
alert(msg); // VoiceOver does not seem to support status role
71+
if (statusContainer.textContent !== msg) {
72+
dom.clearNode(statusContainer2);
73+
insertMessage(statusContainer, msg);
7474
} else {
75-
if (statusContainer.textContent !== msg) {
76-
dom.clearNode(statusContainer2);
77-
insertMessage(statusContainer, msg);
78-
} else {
79-
dom.clearNode(statusContainer);
80-
insertMessage(statusContainer2, msg);
81-
}
75+
dom.clearNode(statusContainer);
76+
insertMessage(statusContainer2, msg);
8277
}
8378
}
8479

src/vs/workbench/contrib/chat/browser/chatWidget.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import * as dom from 'vs/base/browser/dom';
7-
import { alert } from 'vs/base/browser/ui/aria/aria';
7+
import { status } from 'vs/base/browser/ui/aria/aria';
88
import { ITreeContextMenuEvent, ITreeElement } from 'vs/base/browser/ui/tree/tree';
99
import { CancellationToken } from 'vs/base/common/cancellation';
1010
import { Emitter } from 'vs/base/common/event';
@@ -529,7 +529,7 @@ export class ChatAccessibilityService extends Disposable implements IChatAccessi
529529
return;
530530
}
531531
const errorDetails = response.errorDetails ? ` ${response.errorDetails.message}` : '';
532-
alert(response.response.value + errorDetails);
532+
status(response.response.value + errorDetails);
533533
}
534534
}
535535

0 commit comments

Comments
 (0)