Skip to content

Commit 4e159b9

Browse files
authored
[typescript-language-features] Add includeCompletionsWithObjectLiteralMethodSnippets preference (microsoft#145941)
* create flag for object literal method snippet completions * reword description
1 parent cb3c811 commit 4e159b9

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

extensions/typescript-language-features/package.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1178,6 +1178,12 @@
11781178
"default": true,
11791179
"description": "%configuration.suggest.classMemberSnippets.enabled%",
11801180
"scope": "resource"
1181+
},
1182+
"typescript.suggest.objectLiteralMethodSnippets.enabled": {
1183+
"type": "boolean",
1184+
"default": true,
1185+
"description": "%configuration.suggest.objectLiteralMethodSnippets.enabled%",
1186+
"scope": "resource"
11811187
}
11821188
}
11831189
},

extensions/typescript-language-features/package.nls.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,5 +190,6 @@
190190
"codeActions.refactor.rewrite.property.generateAccessors.description": "Generate 'get' and 'set' accessors",
191191
"codeActions.source.organizeImports.title": "Organize imports",
192192
"typescript.findAllFileReferences": "Find File References",
193-
"configuration.suggest.classMemberSnippets.enabled": "Enable/disable snippet completions for class members. Requires using TypeScript 4.5+ in the workspace"
193+
"configuration.suggest.classMemberSnippets.enabled": "Enable/disable snippet completions for class members. Requires using TypeScript 4.5+ in the workspace",
194+
"configuration.suggest.objectLiteralMethodSnippets.enabled": "Enable/disable snippet completions for methods in object literals. Requires using TypeScript 4.7+ in the workspace"
194195
}

extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,8 @@ export default class FileConfigurationManager extends Disposable {
187187
includeCompletionsForImportStatements: config.get<boolean>('suggest.includeCompletionsForImportStatements', true),
188188
includeCompletionsWithSnippetText: config.get<boolean>('suggest.includeCompletionsWithSnippetText', true),
189189
includeCompletionsWithClassMemberSnippets: config.get<boolean>('suggest.classMemberSnippets.enabled', true),
190+
// @ts-expect-error until 4.7
191+
includeCompletionsWithObjectLiteralMethodSnippets: config.get<boolean>('suggest.objectLiteralMethodSnippets.enabled', true),
190192
allowIncompleteCompletions: true,
191193
displayPartsForJSDoc: true,
192194
...getInlayHintsPreferences(config),

0 commit comments

Comments
 (0)