Don't show empty animated agent avatar when the agent doesn't have an icon

roblourens · roblourens · commit 4e6d11e9f112 · 2023-10-27T14:09:52.000-07:00
Fix microsoft/vscode-copilot#2467
diff --git a/src/vs/workbench/contrib/chat/browser/chatListRenderer.ts b/src/vs/workbench/contrib/chat/browser/chatListRenderer.ts
@@ -372,6 +372,9 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch
 			} else if (icon) {
 				const avatarIcon = dom.$(ThemeIcon.asCSSSelector(icon));
 				templateData.agentAvatarContainer.replaceChildren(dom.$('.avatar.codicon-avatar', undefined, avatarIcon));
+			} else {
+				dom.hide(templateData.agentAvatarContainer);
+				return;
 			}
 
 			templateData.agentAvatarContainer.classList.toggle('complete', element.isComplete);

Original file line number	Diff line number	Diff line change
`@@ -372,6 +372,9 @@ export class ChatListItemRenderer extends Disposable implements ITreeRenderer<Ch`
`372`	`372`	`} else if (icon) {`
`373`	`373`	`const avatarIcon = dom.$(ThemeIcon.asCSSSelector(icon));`
`374`	`374`	`templateData.agentAvatarContainer.replaceChildren(dom.$('.avatar.codicon-avatar', undefined, avatarIcon));`
	`375`	`+ } else {`
	`376`	`+ dom.hide(templateData.agentAvatarContainer);`
	`377`	`+ return;`
`375`	`378`	`}`
`376`	`379`
`377`	`380`	`templateData.agentAvatarContainer.classList.toggle('complete', element.isComplete);`