fix: memory leak in extension features tab (microsoft#256887)

SimonSiefke · web-flow · commit 5096b446f497 · 2025-07-22T12:23:46.000+02:00
diff --git a/src/vs/workbench/contrib/extensions/browser/extensionFeaturesTab.ts b/src/vs/workbench/contrib/extensions/browser/extensionFeaturesTab.ts
@@ -736,7 +736,7 @@ class ExtensionFeatureView extends Disposable {
 	}
 
 	private renderElementData(container: HTMLElement, renderer: IExtensionFeatureElementRenderer): void {
-		const elementData = renderer.render(this.manifest);
+		const elementData = this._register(renderer.render(this.manifest));
 		if (elementData.onDidChange) {
 			this._register(elementData.onDidChange(data => {
 				clearNode(container);

Original file line number	Diff line number	Diff line change
`@@ -736,7 +736,7 @@ class ExtensionFeatureView extends Disposable {`
`736`	`736`	`}`
`737`	`737`
`738`	`738`	`private renderElementData(container: HTMLElement, renderer: IExtensionFeatureElementRenderer): void {`
`739`		`- const elementData = renderer.render(this.manifest);`
	`739`	`+ const elementData = this._register(renderer.render(this.manifest));`
`740`	`740`	`if (elementData.onDidChange) {`
`741`	`741`	`this._register(elementData.onDidChange(data => {`
`742`	`742`	`clearNode(container);`