Make some more services lazy (microsoft#161827)

* Lazy service instantiation

* Make resolver eager

Author: lramos15

src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedService.ts

@@ -716,4 +716,4 @@ registerAction2(class extends Action2 {
 	}
 });
 
-registerSingleton(IWalkthroughsService, WalkthroughsService, false);
+registerSingleton(IWalkthroughsService, WalkthroughsService, true);

src/vs/workbench/services/assignment/common/assignmentService.ts

@@ -131,4 +131,4 @@ export class WorkbenchAssignmentService extends BaseAssignmentService {
 	}
 }
 
-registerSingleton(IWorkbenchAssignmentService, WorkbenchAssignmentService, false);
+registerSingleton(IWorkbenchAssignmentService, WorkbenchAssignmentService, true);

src/vs/workbench/services/editor/browser/editorResolverService.ts

@@ -19,7 +19,7 @@ import { QuickPickItem, IKeyMods, IQuickInputService, IQuickPickItem, IQuickPick
 import { localize } from 'vs/nls';
 import { INotificationService, Severity } from 'vs/platform/notification/common/notification';
 import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
-import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
+import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions';
 import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage';
 import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions';
 import { ILogService } from 'vs/platform/log/common/log';
@@ -829,4 +829,4 @@ export class EditorResolverService extends Disposable implements IEditorResolver
 	}
 }
 
-registerSingleton(IEditorResolverService, EditorResolverService, false);
+registerSingleton(IEditorResolverService, EditorResolverService, InstantiationType.Eager);

src/vs/workbench/services/telemetry/browser/telemetryService.ts

@@ -108,4 +108,4 @@ export class TelemetryService extends Disposable implements ITelemetryService {
 	}
 }
 
-registerSingleton(ITelemetryService, TelemetryService, false);
+registerSingleton(ITelemetryService, TelemetryService, true);

src/vs/workbench/services/telemetry/electron-sandbox/telemetryService.ts

@@ -84,4 +84,4 @@ export class TelemetryService extends Disposable implements ITelemetryService {
 	}
 }
 
-registerSingleton(ITelemetryService, TelemetryService, false);
+registerSingleton(ITelemetryService, TelemetryService, true);