Skip to content

Commit 5347f55

Browse files
committed
adding wip
1 parent 30d4de8 commit 5347f55

File tree

3 files changed

+46
-15
lines changed

3 files changed

+46
-15
lines changed

src/vs/editor/contrib/stickyScroll/test/browser/stickyScroll.test.ts

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,11 @@ suite('Sticky Scroll Tests', () => {
137137
enabled: true,
138138
maxLineCount: 5,
139139
defaultModel: 'outlineModel'
140-
}, serviceCollection: serviceCollection
140+
},
141+
envConfig: {
142+
outerHeight: 500
143+
},
144+
serviceCollection: serviceCollection
141145
}, async (editor, _viewModel, instantiationService) => {
142146
const languageService = instantiationService.get(ILanguageFeaturesService);
143147
const languageConfigurationService = instantiationService.get(ILanguageConfigurationService);
@@ -162,7 +166,11 @@ suite('Sticky Scroll Tests', () => {
162166
enabled: true,
163167
maxLineCount: 5,
164168
defaultModel: 'outlineModel'
165-
}, serviceCollection
169+
},
170+
envConfig: {
171+
outerHeight: 500
172+
},
173+
serviceCollection
166174
}, async (editor, _viewModel, instantiationService) => {
167175

168176
const stickyScrollController: StickyScrollController = editor.registerAndInstantiateContribution(StickyScrollController.ID, StickyScrollController);
@@ -211,7 +219,11 @@ suite('Sticky Scroll Tests', () => {
211219
enabled: true,
212220
maxLineCount: 5,
213221
defaultModel: 'outlineModel'
214-
}, serviceCollection
222+
},
223+
envConfig: {
224+
outerHeight: 500
225+
},
226+
serviceCollection
215227
}, async (editor, viewModel, instantiationService) => {
216228

217229
const stickyScrollController: StickyScrollController = editor.registerAndInstantiateContribution(StickyScrollController.ID, StickyScrollController);
@@ -305,7 +317,11 @@ suite('Sticky Scroll Tests', () => {
305317
enabled: true,
306318
maxLineCount: 5,
307319
defaultModel: 'outlineModel'
308-
}, serviceCollection
320+
},
321+
envConfig: {
322+
outerHeight: 500
323+
},
324+
serviceCollection
309325
}, async (editor, _viewModel, instantiationService) => {
310326

311327
const stickyScrollController: StickyScrollController = editor.registerAndInstantiateContribution(StickyScrollController.ID, StickyScrollController);

src/vs/editor/test/browser/config/testConfiguration.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,27 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import { EditorConfiguration, IEnvConfiguration } from 'vs/editor/browser/config/editorConfiguration';
7-
import { EditorFontLigatures, EditorFontVariations, IEditorOptions } from 'vs/editor/common/config/editorOptions';
7+
import { EditorFontLigatures, EditorFontVariations } from 'vs/editor/common/config/editorOptions';
88
import { BareFontInfo, FontInfo } from 'vs/editor/common/config/fontInfo';
9+
import { TestCodeEditorCreationOptions } from 'vs/editor/test/browser/testCodeEditor';
910
import { AccessibilitySupport } from 'vs/platform/accessibility/common/accessibility';
1011
import { TestAccessibilityService } from 'vs/platform/accessibility/test/common/testAccessibilityService';
1112

1213
export class TestConfiguration extends EditorConfiguration {
1314

14-
constructor(opts: IEditorOptions) {
15+
constructor(opts: Readonly<TestCodeEditorCreationOptions>) {
1516
super(false, opts, null, new TestAccessibilityService());
1617
}
1718

1819
protected override _readEnvConfiguration(): IEnvConfiguration {
20+
const envConfig = (this.getRawOptions() as TestCodeEditorCreationOptions).envConfig;
1921
return {
20-
extraEditorClassName: '',
21-
outerWidth: 100,
22-
outerHeight: 100,
23-
emptySelectionClipboard: true,
24-
pixelRatio: 1,
25-
accessibilitySupport: AccessibilitySupport.Unknown
22+
extraEditorClassName: envConfig?.extraEditorClassName ?? '',
23+
outerWidth: envConfig?.outerWidth ?? 100,
24+
outerHeight: envConfig?.outerHeight ?? 100,
25+
emptySelectionClipboard: envConfig?.emptySelectionClipboard ?? true,
26+
pixelRatio: envConfig?.pixelRatio ?? 1,
27+
accessibilitySupport: envConfig?.accessibilitySupport ?? AccessibilitySupport.Unknown
2628
};
2729
}
2830

src/vs/editor/test/browser/testCodeEditor.ts

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import { DisposableStore, IDisposable, toDisposable } from 'vs/base/common/lifecycle';
77
import { mock } from 'vs/base/test/common/mock';
8-
import { EditorConfiguration, IEditorConstructionOptions } from 'vs/editor/browser/config/editorConfiguration';
8+
import { EditorConfiguration } from 'vs/editor/browser/config/editorConfiguration';
99
import { IActiveCodeEditor, ICodeEditor } from 'vs/editor/browser/editorBrowser';
1010
import { ICodeEditorService } from 'vs/editor/browser/services/codeEditorService';
1111
import { View } from 'vs/editor/browser/view';
@@ -30,7 +30,7 @@ import { TestLanguageConfigurationService } from 'vs/editor/test/common/modes/te
3030
import { TestEditorWorkerService } from 'vs/editor/test/common/services/testEditorWorkerService';
3131
import { TestTextResourcePropertiesService } from 'vs/editor/test/common/services/testTextResourcePropertiesService';
3232
import { instantiateTextModel } from 'vs/editor/test/common/testTextModel';
33-
import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility';
33+
import { AccessibilitySupport, IAccessibilityService } from 'vs/platform/accessibility/common/accessibility';
3434
import { TestAccessibilityService } from 'vs/platform/accessibility/test/common/testAccessibilityService';
3535
import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService';
3636
import { TestClipboardService } from 'vs/platform/clipboard/test/common/testClipboardService';
@@ -68,7 +68,7 @@ export interface ITestCodeEditor extends IActiveCodeEditor {
6868
export class TestCodeEditor extends CodeEditorWidget implements ICodeEditor {
6969

7070
//#region testing overrides
71-
protected override _createConfiguration(isSimpleWidget: boolean, options: Readonly<IEditorConstructionOptions>): EditorConfiguration {
71+
protected override _createConfiguration(isSimpleWidget: boolean, options: Readonly<TestCodeEditorCreationOptions>): EditorConfiguration {
7272
return new TestConfiguration(options);
7373
}
7474
protected override _createView(viewModel: ViewModel): [View, boolean] {
@@ -116,6 +116,10 @@ export interface TestCodeEditorCreationOptions extends editorOptions.IEditorOpti
116116
* Defaults to true.
117117
*/
118118
hasTextFocus?: boolean;
119+
/**
120+
* Env configuration
121+
*/
122+
envConfig?: ITestEnvConfiguration;
119123
}
120124

121125
export interface TestCodeEditorInstantiationOptions extends TestCodeEditorCreationOptions {
@@ -125,6 +129,15 @@ export interface TestCodeEditorInstantiationOptions extends TestCodeEditorCreati
125129
serviceCollection?: ServiceCollection;
126130
}
127131

132+
export interface ITestEnvConfiguration {
133+
extraEditorClassName?: string;
134+
outerWidth?: number;
135+
outerHeight?: number;
136+
emptySelectionClipboard?: boolean;
137+
pixelRatio?: number;
138+
accessibilitySupport?: AccessibilitySupport;
139+
}
140+
128141
export function withTestCodeEditor(text: ITextModel | string | string[] | ITextBufferFactory, options: TestCodeEditorInstantiationOptions, callback: (editor: ITestCodeEditor, viewModel: ViewModel, instantiationService: TestInstantiationService) => void): void {
129142
return _withTestCodeEditor(text, options, callback);
130143
}

0 commit comments

Comments
 (0)