Merge pull request microsoft#181257 from microsoft/merogge/udf

meganrogge · web-flow · commit 570a2d8573a3 · 2023-05-01T13:15:37.000-07:00
prevent `undefined` from appearing in `ariaLabel`
diff --git a/src/vs/editor/browser/widget/diffEditorWidget.ts b/src/vs/editor/browser/widget/diffEditorWidget.ts
@@ -1289,7 +1289,7 @@ export class DiffEditorWidget extends Disposable implements editorBrowser.IDiffE
 	}
 
 	private _updateAriaLabel(options: IEditorConstructionOptions): void {
-		let ariaLabel = options.ariaLabel;
+		let ariaLabel = options.ariaLabel ?? '';
 		if (this._options.accessibilityVerbose) {
 			ariaLabel += ariaNavigationTip;
 		} else if (ariaLabel) {

Original file line number	Diff line number	Diff line change
`@@ -1289,7 +1289,7 @@ export class DiffEditorWidget extends Disposable implements editorBrowser.IDiffE`
`1289`	`1289`	`}`
`1290`	`1290`
`1291`	`1291`	`private _updateAriaLabel(options: IEditorConstructionOptions): void {`
`1292`		`- let ariaLabel = options.ariaLabel;`
	`1292`	`+ let ariaLabel = options.ariaLabel ?? '';`
`1293`	`1293`	`if (this._options.accessibilityVerbose) {`
`1294`	`1294`	`ariaLabel += ariaNavigationTip;`
`1295`	`1295`	`} else if (ariaLabel) {`