Skip to content

Commit 57d5861

Browse files
committed
Clean up
1 parent 0a4d4e2 commit 57d5861

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

src/vs/platform/terminal/node/ptyHostService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ export class PtyHostService extends Disposable implements IPtyService {
138138
heartbeatService.onBeat(() => this._handleHeartbeat());
139139
this._handleHeartbeat();
140140

141+
// Handle exit
141142
this._register(connection.onDidProcessExit(e => {
142143
this._onPtyHostExit.fire(e.code);
143144
if (!this._isDisposed) {
@@ -151,7 +152,7 @@ export class PtyHostService extends Disposable implements IPtyService {
151152
}
152153
}));
153154

154-
// Setup logging
155+
// TODO: Setup logging
155156
// this._register(new RemoteLoggerChannelClient(this._loggerService, client.getChannel(TerminalIpcChannels.Logger)));
156157

157158
// Create proxy and forward events
@@ -321,7 +322,6 @@ export class PtyHostService extends Disposable implements IPtyService {
321322
}
322323

323324
private _handleHeartbeat() {
324-
this._logService.info('heartbeat');
325325
this._clearHeartbeatTimeouts();
326326
this._heartbeatFirstTimeout = setTimeout(() => this._handleHeartbeatFirstTimeout(), HeartbeatConstants.BeatInterval * HeartbeatConstants.FirstWaitMultiplier);
327327
if (!this._isResponsive) {

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2142,7 +2142,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
21422142
&& !this._shellLaunchConfig.isExtensionOwnedTerminal &&
21432143
!this._shellLaunchConfig.attachPersistentProcess
21442144
) {
2145-
// this.relaunch();
2145+
this.relaunch();
21462146
return;
21472147
}
21482148
// Re-create statuses

src/vs/workbench/contrib/terminal/electron-sandbox/terminal.contribution.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import { LocalTerminalBackendContribution } from 'vs/workbench/contrib/terminal/
1616

1717
// Register services
1818
registerMainProcessRemoteService(ILocalPtyService, TerminalIpcChannels.LocalPty);
19-
// registerSharedProcessRemoteService(ILocalPtyService, TerminalIpcChannels.LocalPty);
2019
registerSingleton(ITerminalProfileResolverService, ElectronTerminalProfileResolverService, InstantiationType.Delayed);
2120

2221
// Register workbench contributions

0 commit comments

Comments
 (0)