Use an option over a protected override

Author: Tyriar

src/vs/workbench/contrib/codeEditor/browser/find/simpleFindWidget.ts

@@ -37,6 +37,7 @@ interface IFindOptions {
 	appendCaseSensitiveLabel?: string;
 	appendRegexLabel?: string;
 	appendWholeWordsLabel?: string;
+	matchesLimit?: number;
 	type?: 'Terminal' | 'Webview';
 }
 
@@ -52,6 +53,7 @@ export abstract class SimpleFindWidget extends Widget {
 	private readonly _updateHistoryDelayer: Delayer<void>;
 	private readonly prevBtn: SimpleButton;
 	private readonly nextBtn: SimpleButton;
+	private readonly _matchesLimit: number;
 	private _matchesCount: HTMLElement | undefined;
 
 	private _isVisible: boolean = false;
@@ -68,6 +70,8 @@ export abstract class SimpleFindWidget extends Widget {
 	) {
 		super();
 
+		this._matchesLimit = options.matchesLimit ?? Number.MAX_SAFE_INTEGER;
+
 		this._findInput = this._register(new ContextScopedFindInput(null, contextViewService, {
 			label: NLS_FIND_INPUT_LABEL,
 			placeholder: NLS_FIND_INPUT_PLACEHOLDER,
@@ -208,10 +212,6 @@ export abstract class SimpleFindWidget extends Widget {
 	protected abstract _onFindInputFocusTrackerBlur(): void;
 	protected abstract _getResultCount(): Promise<{ resultIndex: number; resultCount: number } | undefined>;
 
-	protected get _matchesLimit(): number {
-		return Number.MAX_SAFE_INTEGER;
-	}
-
 	protected get inputValue() {
 		return this._findInput.getValue();
 	}

src/vs/workbench/contrib/terminalContrib/find/browser/terminalFindWidget.ts

@@ -19,8 +19,6 @@ export class TerminalFindWidget extends SimpleFindWidget {
 	private _findWidgetFocused: IContextKey<boolean>;
 	private _findWidgetVisible: IContextKey<boolean>;
 
-	override get _matchesLimit() { return XtermTerminalConstants.SearchHighlightLimit; }
-
 	constructor(
 		private _instance: ITerminalInstance,
 		@IContextViewService _contextViewService: IContextViewService,
@@ -29,7 +27,7 @@ export class TerminalFindWidget extends SimpleFindWidget {
 		@IThemeService private readonly _themeService: IThemeService,
 		@IConfigurationService private readonly _configurationService: IConfigurationService
 	) {
-		super({ showCommonFindToggles: true, checkImeCompletionState: true, showResultCount: true, type: 'Terminal' }, _contextViewService, _contextKeyService, keybindingService);
+		super({ showCommonFindToggles: true, checkImeCompletionState: true, showResultCount: true, type: 'Terminal', matchesLimit: XtermTerminalConstants.SearchHighlightLimit }, _contextViewService, _contextKeyService, keybindingService);
 
 		this._register(this.state.onFindReplaceStateChange(() => {
 			this.show();