Skip to content

Commit 5912ad3

Browse files
committed
Merge branch 'main' into joh/rewrite-privates
2 parents 424a88c + e3cc677 commit 5912ad3

File tree

166 files changed

+4027
-2574
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

166 files changed

+4027
-2574
lines changed

.eslintignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
**/extensions/notebook-renderers/renderer-out/index.js
1414
**/extensions/simple-browser/media/index.js
1515
**/extensions/typescript-language-features/test-workspace/**
16+
**/extensions/typescript-language-features/extension.webpack.config.js
17+
**/extensions/typescript-language-features/extension-browser.webpack.config.js
18+
**/extensions/typescript-language-features/web/**
1619
**/extensions/vscode-api-tests/testWorkspace/**
1720
**/extensions/vscode-api-tests/testWorkspace2/**
1821
**/fixtures/**

.github/classifier.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@
133133
"rename": {"assign": ["jrieken"]},
134134
"scm": {"assign": ["lszomoru"]},
135135
"screencast-mode": {"assign": ["lszomoru"]},
136-
"search": {"assign": ["roblourens", "andreamah"]},
136+
"search": {"assign": ["andreamah"]},
137137
"search-editor": {"assign": ["roblourens"]},
138138
"search-replace": {"assign": ["sandy081"]},
139139
"semantic-tokens": {"assign": ["alexdima", "aeschli"]},

build/azure-pipelines/cli/prepare.js

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/azure-pipelines/cli/prepare.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@ const setLauncherEnvironmentVars = () => {
4646
['VSCODE_CLI_VERSION', packageJson.version],
4747
['VSCODE_CLI_UPDATE_ENDPOINT', product.updateUrl],
4848
['VSCODE_CLI_QUALITY', product.quality],
49+
['VSCODE_CLI_NAME_SHORT', product.nameShort],
50+
['VSCODE_CLI_NAME_LONG', product.nameLong],
51+
['VSCODE_CLI_APPLICATION_NAME', product.applicationName],
4952
['VSCODE_CLI_COMMIT', commit],
5053
[
5154
'VSCODE_CLI_WIN32_APP_IDS',

build/gulpfile.extensions.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ const compilations = [
6464
'references-view/tsconfig.json',
6565
'simple-browser/tsconfig.json',
6666
'typescript-language-features/test-workspace/tsconfig.json',
67+
'typescript-language-features/web/tsconfig.json',
6768
'typescript-language-features/tsconfig.json',
6869
'vscode-api-tests/tsconfig.json',
6970
'vscode-colorize-tests/tsconfig.json',

build/lib/extensions.js

Lines changed: 6 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/lib/extensions.ts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -506,20 +506,14 @@ export async function webpackExtensions(taskName: string, isWatch: boolean, webp
506506

507507
for (const { configPath, outputRoot } of webpackConfigLocations) {
508508
const configOrFnOrArray = require(configPath);
509-
function addConfig(configOrFn: webpack.Configuration | Function) {
510-
let config;
511-
if (typeof configOrFn === 'function') {
512-
config = (configOrFn as Function)({}, {});
509+
function addConfig(configOrFnOrArray: webpack.Configuration | ((env: unknown,args: unknown) => webpack.Configuration) | webpack.Configuration[]) {
510+
for (const configOrFn of Array.isArray(configOrFnOrArray) ? configOrFnOrArray : [configOrFnOrArray]) {
511+
const config = typeof configOrFn === 'function' ? configOrFn({}, {}) : configOrFn;
512+
if (outputRoot) {
513+
config.output!.path = path.join(outputRoot, path.relative(path.dirname(configPath), config.output!.path!));
514+
}
513515
webpackConfigs.push(config);
514-
} else {
515-
config = configOrFn;
516516
}
517-
518-
if (outputRoot) {
519-
config.output.path = path.join(outputRoot, path.relative(path.dirname(configPath), config.output.path));
520-
}
521-
522-
webpackConfigs.push(configOrFn);
523517
}
524518
addConfig(configOrFnOrArray);
525519
}

0 commit comments

Comments
 (0)