Skip to content

Commit 5a927a7

Browse files
aiday-maraiday-mar
committed
adding review chanegs
1 parent 2b65bd2 commit 5a927a7

File tree

6 files changed

+130
-131
lines changed

6 files changed

+130
-131
lines changed

‎src/vs/base/browser/ui/hover/hover.css

Lines changed: 50 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -3,68 +3,67 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
.monaco-hover .resizable-hover {
6+
.monaco-hover {
77
z-index: 50;
88
}
99

10-
.monaco-hover {
10+
.monaco-hover-container {
1111
cursor: default;
1212
position: absolute;
1313
overflow: hidden;
14-
z-index: 50;
1514
user-select: text;
1615
-webkit-user-select: text;
1716
box-sizing: initial;
1817
animation: fadein 100ms linear;
1918
line-height: 1.5em;
2019
}
2120

22-
.monaco-hover.hidden {
21+
.monaco-hover-container.hidden {
2322
display: none;
2423
}
2524

26-
.monaco-hover a:hover:not(.disabled) {
25+
.monaco-hover-container a:hover:not(.disabled) {
2726
cursor: pointer;
2827
}
2928

30-
.monaco-hover .hover-contents:not(.html-hover-contents) {
29+
.monaco-hover-container .hover-contents:not(.html-hover-contents) {
3130
padding: 4px 8px;
3231
}
3332

34-
.monaco-hover .markdown-hover > .hover-contents:not(.code-hover-contents) {
33+
.monaco-hover-container .markdown-hover > .hover-contents:not(.code-hover-contents) {
3534
word-wrap: break-word;
3635
}
3736

38-
.monaco-hover .markdown-hover > .hover-contents:not(.code-hover-contents) hr {
37+
.monaco-hover-container .markdown-hover > .hover-contents:not(.code-hover-contents) hr {
3938
min-width: 100%;
4039
}
4140

42-
.monaco-hover p,
43-
.monaco-hover .code,
44-
.monaco-hover ul,
45-
.monaco-hover h1,
46-
.monaco-hover h2,
47-
.monaco-hover h3,
48-
.monaco-hover h4,
49-
.monaco-hover h5,
50-
.monaco-hover h6 {
41+
.monaco-hover-container p,
42+
.monaco-hover-container .code,
43+
.monaco-hover-container ul,
44+
.monaco-hover-container h1,
45+
.monaco-hover-container h2,
46+
.monaco-hover-container h3,
47+
.monaco-hover-container h4,
48+
.monaco-hover-container h5,
49+
.monaco-hover-container h6 {
5150
margin: 8px 0;
5251
}
5352

54-
.monaco-hover h1,
55-
.monaco-hover h2,
56-
.monaco-hover h3,
57-
.monaco-hover h4,
58-
.monaco-hover h5,
59-
.monaco-hover h6 {
53+
.monaco-hover-container h1,
54+
.monaco-hover-container h2,
55+
.monaco-hover-container h3,
56+
.monaco-hover-container h4,
57+
.monaco-hover-container h5,
58+
.monaco-hover-container h6 {
6059
line-height: 1.1;
6160
}
6261

63-
.monaco-hover code {
62+
.monaco-hover-container code {
6463
font-family: var(--monaco-monospace-font);
6564
}
6665

67-
.monaco-hover hr {
66+
.monaco-hover-container hr {
6867
box-sizing: border-box;
6968
border-left: 0px;
7069
border-right: 0px;
@@ -75,100 +74,100 @@
7574
height: 1px;
7675
}
7776

78-
.monaco-hover p:first-child,
79-
.monaco-hover .code:first-child,
80-
.monaco-hover ul:first-child {
77+
.monaco-hover-container p:first-child,
78+
.monaco-hover-container .code:first-child,
79+
.monaco-hover-container ul:first-child {
8180
margin-top: 0;
8281
}
8382

84-
.monaco-hover p:last-child,
85-
.monaco-hover .code:last-child,
86-
.monaco-hover ul:last-child {
83+
.monaco-hover-container p:last-child,
84+
.monaco-hover-container .code:last-child,
85+
.monaco-hover-container ul:last-child {
8786
margin-bottom: 0;
8887
}
8988

9089
/* MarkupContent Layout */
91-
.monaco-hover ul {
90+
.monaco-hover-container ul {
9291
padding-left: 20px;
9392
}
94-
.monaco-hover ol {
93+
.monaco-hover-container ol {
9594
padding-left: 20px;
9695
}
9796

98-
.monaco-hover li > p {
97+
.monaco-hover-container li > p {
9998
margin-bottom: 0;
10099
}
101100

102-
.monaco-hover li > ul {
101+
.monaco-hover-container li > ul {
103102
margin-top: 0;
104103
}
105104

106-
.monaco-hover code {
105+
.monaco-hover-container code {
107106
border-radius: 3px;
108107
padding: 0 0.4em;
109108
}
110109

111-
.monaco-hover .monaco-tokenized-source {
112-
white-space: pre-wrap;
110+
.monaco-hover-container .monaco-tokenized-source {
111+
white-space: pre-wrap;
113112
}
114113

115-
.monaco-hover .hover-row.status-bar {
114+
.monaco-hover-container .hover-row.status-bar {
116115
font-size: 12px;
117116
line-height: 22px;
118117
}
119118

120-
.monaco-hover .hover-row.status-bar .info {
119+
.monaco-hover-container .hover-row.status-bar .info {
121120
font-style: italic;
122121
padding: 0px 8px;
123122
}
124123

125-
.monaco-hover .hover-row.status-bar .actions {
124+
.monaco-hover-container .hover-row.status-bar .actions {
126125
display: flex;
127126
padding: 0px 8px;
128127
}
129128

130-
.monaco-hover .hover-row.status-bar .actions .action-container {
129+
.monaco-hover-container .hover-row.status-bar .actions .action-container {
131130
margin-right: 16px;
132131
cursor: pointer;
133132
}
134133

135-
.monaco-hover .hover-row.status-bar .actions .action-container .action .icon {
134+
.monaco-hover-container .hover-row.status-bar .actions .action-container .action .icon {
136135
padding-right: 4px;
137136
}
138137

139-
.monaco-hover .markdown-hover .hover-contents .codicon {
138+
.monaco-hover-container .markdown-hover .hover-contents .codicon {
140139
color: inherit;
141140
font-size: inherit;
142141
vertical-align: middle;
143142
}
144143

145-
.monaco-hover .hover-contents a.code-link:hover,
146-
.monaco-hover .hover-contents a.code-link {
144+
.monaco-hover-container .hover-contents a.code-link:hover,
145+
.monaco-hover-container .hover-contents a.code-link {
147146
color: inherit;
148147
}
149148

150-
.monaco-hover .hover-contents a.code-link:before {
149+
.monaco-hover-container .hover-contents a.code-link:before {
151150
content: '(';
152151
}
153152

154-
.monaco-hover .hover-contents a.code-link:after {
153+
.monaco-hover-container .hover-contents a.code-link:after {
155154
content: ')';
156155
}
157156

158-
.monaco-hover .hover-contents a.code-link > span {
157+
.monaco-hover-container .hover-contents a.code-link > span {
159158
text-decoration: underline;
160159
/** Hack to force underline to show **/
161160
border-bottom: 1px solid transparent;
162161
text-underline-position: under;
163162
color: var(--vscode-textLink-foreground);
164163
}
165164

166-
.monaco-hover .hover-contents a.code-link > span:hover {
165+
.monaco-hover-container .hover-contents a.code-link > span:hover {
167166
color: var(--vscode-textLink-activeForeground);
168167
}
169168

170169
/** Spans in markdown hovers need a margin-bottom to avoid looking cramped: https://github.com/microsoft/vscode/issues/101496 **/
171-
.monaco-hover .markdown-hover .hover-contents:not(.code-hover-contents):not(.html-hover-contents) span {
170+
.monaco-hover-container .markdown-hover .hover-contents:not(.code-hover-contents):not(.html-hover-contents) span {
172171
margin-bottom: 4px;
173172
display: inline-block;
174173
}

‎src/vs/base/browser/ui/hover/hoverWidget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export class HoverWidget extends Disposable {
2626
super();
2727

2828
this.containerDomNode = document.createElement('div');
29-
this.containerDomNode.className = 'monaco-hover';
29+
this.containerDomNode.className = 'monaco-hover-container';
3030
this.containerDomNode.tabIndex = 0;
3131
this.containerDomNode.setAttribute('role', 'tooltip');
3232

0 commit comments

Comments
 (0)