Run our custom eslint rules using ts-node (microsoft#157532)

* Run our custom eslint rules using ts-node

Use `ts-node` to run our custom eslint rules.  This lets us delete the pre-compiled js. It also means you can don't have to compile the rules while editing them

As part of this change, I've also switched us to using an eslint plugin instead of a rulesDir. This is now the preferred way to ship custom rules

* Fix two more disables

* Move ts-node to project root

* Enable transpileOnly

Author: mjbvz

.eslintrc.json

@@ -8,7 +8,8 @@
 	"plugins": [
 		"@typescript-eslint",
 		"jsdoc",
-		"header"
+		"header",
+		"@vscode"
 	],
 	"rules": {
 		"constructor-super": "warn",
@@ -61,17 +62,17 @@
 				]
 			}
 		],
-		"code-no-unused-expressions": [
+		"@vscode/code-no-unused-expressions": [
 			"warn",
 			{
 				"allowTernary": true
 			}
 		],
-		"code-translation-remind": "warn",
-		"code-no-nls-in-standalone-editor": "warn",
-		"code-no-standalone-editor": "warn",
-		"code-no-unexternalized-strings": "warn",
-		"code-layering": [
+		"@vscode/code-translation-remind": "warn",
+		"@vscode/code-no-nls-in-standalone-editor": "warn",
+		"@vscode/code-no-standalone-editor": "warn",
+		"@vscode/code-no-unexternalized-strings": "warn",
+		"@vscode/code-layering": [
 			"warn",
 			{
 				"common": [],
@@ -122,8 +123,8 @@
 				"**/*.test.ts"
 			],
 			"rules": {
-				"code-no-test-only": "error",
-				"code-no-unexternalized-strings": "off"
+				"@vscode/code-no-test-only": "error",
+				"@vscode/code-no-unexternalized-strings": "off"
 			}
 		},
 		{
@@ -132,14 +133,14 @@
 				"**/vscode.proposed.*.d.ts"
 			],
 			"rules": {
-				"vscode-dts-create-func": "warn",
-				"vscode-dts-literal-or-types": "warn",
-				"vscode-dts-interface-naming": "warn",
-				"vscode-dts-cancellation": "warn",
-				"vscode-dts-use-thenable": "warn",
-				"vscode-dts-region-comments": "warn",
-				"vscode-dts-vscode-in-comments": "warn",
-				"vscode-dts-provider-naming": [
+				"@vscode/vscode-dts-create-func": "warn",
+				"@vscode/vscode-dts-literal-or-types": "warn",
+				"@vscode/vscode-dts-interface-naming": "warn",
+				"@vscode/vscode-dts-cancellation": "warn",
+				"@vscode/vscode-dts-use-thenable": "warn",
+				"@vscode/vscode-dts-region-comments": "warn",
+				"@vscode/vscode-dts-vscode-in-comments": "warn",
+				"@vscode/vscode-dts-provider-naming": [
 					"warn",
 					{
 						"allowed": [
@@ -154,7 +155,7 @@
 						]
 					}
 				],
-				"vscode-dts-event-naming": [
+				"@vscode/vscode-dts-event-naming": [
 					"warn",
 					{
 						"allowed": [
@@ -200,8 +201,8 @@
 				"src/**/*.ts"
 			],
 			"rules": {
-				"code-no-look-behind-regex": "warn",
-				"code-import-patterns": [
+				"@vscode/code-no-look-behind-regex": "warn",
+				"@vscode/code-import-patterns": [
 					"warn",
 					{
 						// imports that are allowed in all files of layers:
@@ -576,7 +577,7 @@
 				"test/**/*.ts"
 			],
 			"rules": {
-				"code-import-patterns": [
+				"@vscode/code-import-patterns": [
 					"warn",
 					{
 						"target": "test/smoke/**",

.vscode/settings.json

@@ -41,11 +41,6 @@
 			}
 		}
 	],
-	"eslint.options": {
-		"rulePaths": [
-			"./build/lib/eslint"
-		]
-	},
 	"typescript.tsdk": "node_modules/typescript/lib",
 	"npm.exclude": "**/extensions/**",
 	"npm.packageManager": "yarn",

build/eslint.js

@@ -13,8 +13,7 @@ function eslint() {
 		.src(eslintFilter, { base: '.', follow: true, allowEmpty: true })
 		.pipe(
 			gulpeslint({
-				configFile: '.eslintrc.json',
-				rulePaths: ['./build/lib/eslint'],
+				configFile: '.eslintrc.json'
 			})
 		)
 		.pipe(gulpeslint.formatEach('compact'))

build/hygiene.js

@@ -173,8 +173,7 @@ function hygiene(some, linting = true) {
 				.pipe(filter(eslintFilter))
 				.pipe(
 					gulpeslint({
-						configFile: '.eslintrc.json',
-						rulePaths: ['./build/lib/eslint'],
+						configFile: '.eslintrc.json'
 					})
 				)
 				.pipe(gulpeslint.formatEach('compact'))

build/lib/eslint/code-import-patterns.ts renamed to build/lib/eslint-plugin-vscode/code-import-patterns.ts

@@ -6,7 +6,7 @@
 import * as eslint from 'eslint';
 import { TSESTree } from '@typescript-eslint/experimental-utils';
 import * as path from 'path';
-import * as minimatch from 'minimatch';
+import minimatch from 'minimatch';
 import { createImportRuleListener } from './utils';
 
 const REPO_ROOT = path.normalize(path.join(__dirname, '../../../'));