Skip to content

Commit 5ca03d6

Browse files
authored
console error when issue reporter fails (microsoft#205920)
* throw some console errors here and there * error checking
1 parent 91f71cd commit 5ca03d6

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

src/vs/code/electron-sandbox/issue/issueReporterService.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -926,6 +926,7 @@ export class IssueReporter extends Disposable {
926926

927927
const response = await fetch(url, init);
928928
if (!response.ok) {
929+
console.error('Invalid GitHub URL provided.');
929930
return false;
930931
}
931932
const result = await response.json();
@@ -984,6 +985,7 @@ export class IssueReporter extends Disposable {
984985

985986
let issueUrl = hasUri ? this.getExtensionBugsUrl() : this.getIssueUrl();
986987
if (!issueUrl) {
988+
console.error('No issue url found');
987989
return false;
988990
}
989991

@@ -1004,6 +1006,7 @@ export class IssueReporter extends Disposable {
10041006
try {
10051007
url = await this.writeToClipboard(baseUrl, issueBody);
10061008
} catch (_) {
1009+
console.error('Writing to clipboard failed');
10071010
return false;
10081011
}
10091012
}
@@ -1040,6 +1043,8 @@ export class IssueReporter extends Disposable {
10401043
owner: match[1],
10411044
repositoryName: match[2]
10421045
};
1046+
} else {
1047+
console.error('No GitHub match');
10431048
}
10441049

10451050
return undefined;

src/vs/workbench/services/issue/electron-sandbox/issueService.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,13 @@ export class NativeIssueService implements IWorkbenchIssueService {
185185
githubAccessToken
186186
}, dataOverrides);
187187

188+
if (issueReporterData.extensionId) {
189+
const extensionExists = extensionData.some(extension => extension.id === issueReporterData.extensionId);
190+
if (!extensionExists) {
191+
console.error(`Extension with ID ${issueReporterData.extensionId} does not exist.`);
192+
}
193+
}
194+
188195
if (issueReporterData.extensionId && this.extensionIdentifierSet.has(issueReporterData.extensionId)) {
189196
ipcRenderer.send(`vscode:triggerReporterMenuResponse:${issueReporterData.extensionId}`, issueReporterData);
190197
this.extensionIdentifierSet.delete(new ExtensionIdentifier(issueReporterData.extensionId));

0 commit comments

Comments
 (0)