Fix IHoverDelegateOptions to use new options format

Fixes microsoft#199070

Author: Tyriar

src/vs/base/browser/ui/iconLabel/iconHoverDelegate.ts

@@ -26,28 +26,35 @@ export interface IHoverDelegateOptions extends IUpdatableHoverOptions {
 	 * dispose method is required.
 	 */
 	target: IHoverDelegateTarget | HTMLElement;
-	/**
-	 * Position of the hover. The default is to show above the target. This option will be ignored
-	 * if there is not enough room to layout the hover in the specified position, unless the
-	 * forcePosition option is set.
-	 */
-	hoverPosition?: HoverPosition;
-	/**
-	 * Whether to show the hover pointer
-	 */
-	showPointer?: boolean;
-	/**
-	 * Whether to skip the fade in animation, this should be used when hovering from one hover to
-	 * another in the same group so it looks like the hover is moving from one element to the other.
-	 */
-	skipFadeInAnimation?: boolean;
 	/**
 	 * The container to pass to {@link IContextViewProvider.showContextView} which renders the hover
 	 * in. This is particularly useful for more natural tab focusing behavior, where the hover is
 	 * created as the next tab index after the element being hovered and/or to workaround the
 	 * element's container hiding on `focusout`.
 	 */
 	container?: HTMLElement;
+	/**
+	 * Options that defines where the hover is positioned.
+	 */
+	position?: {
+		/**
+		 * Position of the hover. The default is to show above the target. This option will be ignored
+		 * if there is not enough room to layout the hover in the specified position, unless the
+		 * forcePosition option is set.
+		 */
+		hoverPosition?: HoverPosition;
+	};
+	appearance?: {
+		/**
+		 * Whether to show the hover pointer
+		 */
+		showPointer?: boolean;
+		/**
+		 * Whether to skip the fade in animation, this should be used when hovering from one hover to
+		 * another in the same group so it looks like the hover is moving from one element to the other.
+		 */
+		skipFadeInAnimation?: boolean;
+	};
 }
 
 export interface IHoverDelegate {

src/vs/base/browser/ui/iconLabel/iconLabelHover.ts

@@ -124,9 +124,13 @@ class UpdatableHoverWidget implements IDisposable {
 			const hoverOptions: IHoverDelegateOptions = {
 				content,
 				target: this.target,
-				showPointer: this.hoverDelegate.placement === 'element',
-				hoverPosition: HoverPosition.BELOW,
-				skipFadeInAnimation: !this.fadeInAnimation || !!oldHoverWidget, // do not fade in if the hover is already showing
+				appearance: {
+					showPointer: this.hoverDelegate.placement === 'element',
+					skipFadeInAnimation: !this.fadeInAnimation || !!oldHoverWidget, // do not fade in if the hover is already showing
+				},
+				position: {
+					hoverPosition: HoverPosition.BELOW,
+				},
 				...options
 			};
 

src/vs/platform/quickinput/browser/quickInputList.ts

@@ -860,9 +860,13 @@ export class QuickInputList {
 			linkHandler: (url) => {
 				this.options.linkOpenerDelegate(url);
 			},
-			showPointer: true,
+			appearance: {
+				showPointer: true,
+			},
 			container: this.container,
-			hoverPosition: HoverPosition.RIGHT
+			position: {
+				hoverPosition: HoverPosition.RIGHT
+			}
 		}, false);
 	}
 

src/vs/workbench/contrib/notebook/browser/view/cellParts/cellStatusPart.ts

@@ -77,7 +77,8 @@ export class CellEditorStatusBar extends CellContentPart {
 			private _lastHoverHideTime: number = 0;
 
 			readonly showHover = (options: IHoverDelegateOptions) => {
-				options.hoverPosition = HoverPosition.ABOVE;
+				options.position = options.position ?? {};
+				options.position.hoverPosition = HoverPosition.ABOVE;
 				return hoverService.showHover(options);
 			};