deprecate self-dispose object/pattern (microsoft#250815)

migrate cell entry fyi @DonJayamanne

re microsoft#248366

Author: jrieken

src/vs/base/common/observableDisposable.ts

@@ -6,9 +6,7 @@
 import { Disposable, DisposableStore, IDisposable, toDisposable } from './lifecycle.js';
 
 /**
- * Disposable object that tracks its {@linkcode isDisposed} state
- * as a public attribute and provides the {@linkcode onDispose}
- * event to subscribe to.
+* @deprecated do not use this, https://github.com/microsoft/vscode/issues/248366
  */
 export abstract class ObservableDisposable extends Disposable {
 	/**
@@ -68,16 +66,12 @@ export abstract class ObservableDisposable extends Disposable {
 }
 
 /**
- * Type for a non-disposed object `TObject`.
+ * @deprecated do not use this, https://github.com/microsoft/vscode/issues/248366
  */
 type TNotDisposed<TObject extends { isDisposed: boolean }> = TObject & { isDisposed: false };
 
 /**
- * Asserts that a provided `object` is not `disposed` yet,
- * e.g., its `disposed` property is `false`.
- *
- * @throws if the provided `object.disposed` equal to `false`.
- * @param error Error message or error object to throw if assertion fails.
+ * @deprecated do not use this, https://github.com/microsoft/vscode/issues/248366
  */
 export function assertNotDisposed<TObject extends { isDisposed: boolean }>(
 	object: TObject,

src/vs/workbench/contrib/chat/browser/chatEditing/notebook/chatEditingNotebookCellEntry.ts

@@ -4,9 +4,8 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { RunOnceScheduler } from '../../../../../../base/common/async.js';
-import { DisposableStore, toDisposable } from '../../../../../../base/common/lifecycle.js';
+import { Disposable, DisposableStore, toDisposable } from '../../../../../../base/common/lifecycle.js';
 import { ITransaction, IObservable, observableValue, autorun, transaction } from '../../../../../../base/common/observable.js';
-import { ObservableDisposable } from '../../../../../../base/common/observableDisposable.js';
 import { themeColorFromId } from '../../../../../../base/common/themables.js';
 import { URI } from '../../../../../../base/common/uri.js';
 import { EditOperation, ISingleEditOperation } from '../../../../../../editor/common/core/editOperation.js';
@@ -37,7 +36,7 @@ import { pendingRewriteMinimap } from '../chatEditingModifiedFileEntry.js';
  * Most of the code has been borrowed from there, as a cell is effectively a document.
  * Hence most of the same functionality applies.
  */
-export class ChatEditingNotebookCellEntry extends ObservableDisposable {
+export class ChatEditingNotebookCellEntry extends Disposable {
 	private static readonly _lastEditDecorationOptions = ModelDecorationOptions.register({
 		isWholeLine: true,
 		description: 'chat-last-edit',
@@ -60,6 +59,10 @@ export class ChatEditingNotebookCellEntry extends ObservableDisposable {
 	});
 
 
+	public get isDisposed(): boolean {
+		return this._store.isDisposed;
+	}
+
 	private _edit: StringEdit = StringEdit.empty;
 	private _isEditFromUs: boolean = false;
 	public get isEditFromUs(): boolean {