Use description & detail when calculating id for the identity provider (microsoft#210803)

* Use description & detail when calculating id for the identity provider

Fixes microsoft#209842

* better logic

Author: TylerLeonhardt

src/vs/platform/quickinput/browser/quickInputTree.ts

@@ -744,12 +744,20 @@ export class QuickInputTree extends Disposable {
 				identityProvider: {
 					getId: element => {
 						// always prefer item over separator because if item is defined, it must be the main item type
-						// always prefer a defined id if one was specified and use label as a fallback
-						return element.item?.id
-							?? element.item?.label
-							?? element.separator?.id
-							?? element.separator?.label
-							?? '';
+						const mainItem = element.item || element.separator;
+						if (mainItem === undefined) {
+							return '';
+						}
+						// always prefer a defined id if one was specified and use "label + description + detail" as a fallback
+						if (mainItem.id !== undefined) {
+							return mainItem.id;
+						}
+						let id = `label:${mainItem.label}`;
+						id += `$$description:${mainItem.description}`;
+						if (mainItem.type !== 'separator') {
+							id += `$$detail:${mainItem.detail}`;
+						}
+						return id;
 					},
 				},
 				alwaysConsumeMouseWheel: true