Skip to content

Commit 600b519

Browse files
authored
Render the tree once rather than once per key (microsoft#187742)
1 parent a4fde6f commit 600b519

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,9 +1356,11 @@ export class SettingsEditor2 extends EditorPane {
13561356
keys.forEach(key => this.settingsTreeModel.updateElementsByName(key));
13571357
}
13581358

1359-
keys.forEach(key => this.renderTree(key));
1359+
// Attempt to render the tree once rather than
1360+
// once for each key to avoid redundant calls to this.refreshTree()
1361+
this.renderTree();
13601362
} else {
1361-
return this.renderTree();
1363+
this.renderTree();
13621364
}
13631365
}
13641366

0 commit comments

Comments
 (0)