Skip encoding URI.toString in download service to avoid a malformed url (microsoft#151966)

tanhakabir · web-flow · commit 6010baac72f5 · 2022-06-13T11:09:16.000-07:00
Ref: https://github.com/microsoft/vscode-update-server/issues/95
diff --git a/src/vs/platform/download/common/downloadService.ts b/src/vs/platform/download/common/downloadService.ts
@@ -25,7 +25,7 @@ export class DownloadService implements IDownloadService {
 			await this.fileService.copy(resource, target);
 			return;
 		}
-		const options = { type: 'GET', url: resource.toString() };
+		const options = { type: 'GET', url: resource.toString(true) };
 		const context = await this.requestService.request(options, cancellationToken);
 		if (context.res.statusCode === 200) {
 			await this.fileService.writeFile(target, context.stream);

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export class DownloadService implements IDownloadService {`
`25`	`25`	`await this.fileService.copy(resource, target);`
`26`	`26`	`return;`
`27`	`27`	`}`
`28`		`- const options = { type: 'GET', url: resource.toString() };`
	`28`	`+ const options = { type: 'GET', url: resource.toString(true) };`
`29`	`29`	`const context = await this.requestService.request(options, cancellationToken);`
`30`	`30`	`if (context.res.statusCode === 200) {`
`31`	`31`	`await this.fileService.writeFile(target, context.stream);`