Skip to content

Commit 61b0c4f

Browse files
authored
Merge branch 'main' into merogge/fix-task-reconnection
2 parents 58969b4 + 84fc1ff commit 61b0c4f

File tree

16 files changed

+72
-49
lines changed

16 files changed

+72
-49
lines changed

.github/workflows/no-yarn-lock-changes.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ jobs:
2424
- name: Get file changes
2525
uses: trilom/file-changes-action@ce38c8ce2459ca3c303415eec8cb0409857b4272
2626
if: ${{ steps.control.outputs.should_run == 'true' }}
27-
- name: Check for yarn.lock changes
27+
- name: Check for lockfile changes
2828
if: ${{ steps.control.outputs.should_run == 'true' }}
2929
run: |
30-
cat $HOME/files.json | jq -e 'any(test("yarn\\.lock$")) | not' \
31-
|| (echo "Changes to yarn.lock files aren't allowed in PRs." && exit 1)
30+
cat $HOME/files.json | jq -e 'any(test("yarn\\.lock$|Cargo\\.lock$")) | not' \
31+
|| (echo "Changes to yarn.lock/Cargo.lock files aren't allowed in PRs." && exit 1)

.vscode/notebooks/api.github-issues

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
{
88
"kind": 2,
99
"language": "github-issues",
10-
"value": "$repo=repo:microsoft/vscode\n$milestone=milestone:\"June 2023\""
10+
"value": "$repo=repo:microsoft/vscode\n$milestone=milestone:\"July 2023\""
1111
},
1212
{
1313
"kind": 1,

.vscode/notebooks/endgame.github-issues

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
{
88
"kind": 2,
99
"language": "github-issues",
10-
"value": "$REPOS=repo:microsoft/vscode repo:microsoft/vscode-remote-release repo:microsoft/vscode-copilot repo:microsoft/vscode-copilot-release repo:microsoft/vscode-js-debug repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-dev repo:microsoft/vscode-unpkg repo:microsoft/vscode-references-view repo:microsoft/vscode-anycode repo:microsoft/vscode-hexeditor repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-livepreview repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-remote-repositories-github repo:microsoft/monaco-editor repo:microsoft/vscode-vsce repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-livepreview repo:microsoft/vscode-livepreview repo:microsoft/vscode-python repo:microsoft/vscode-python-debugger repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-l10n repo:microsoft/vscode-remote-tunnels\n\n$MILESTONE=milestone:\"June 2023\""
10+
"value": "$REPOS=repo:microsoft/vscode repo:microsoft/vscode-remote-release repo:microsoft/vscode-copilot repo:microsoft/vscode-copilot-release repo:microsoft/vscode-js-debug repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-dev repo:microsoft/vscode-unpkg repo:microsoft/vscode-references-view repo:microsoft/vscode-anycode repo:microsoft/vscode-hexeditor repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-livepreview repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-remote-repositories-github repo:microsoft/monaco-editor repo:microsoft/vscode-vsce repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-livepreview repo:microsoft/vscode-livepreview repo:microsoft/vscode-python repo:microsoft/vscode-python-debugger repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-l10n repo:microsoft/vscode-remote-tunnels\n\n$MILESTONE=milestone:\"July 2023\""
1111
},
1212
{
1313
"kind": 1,

.vscode/notebooks/my-endgame.github-issues

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
{
88
"kind": 2,
99
"language": "github-issues",
10-
"value": "$REPOS=repo:microsoft/vscode repo:microsoft/vscode-remote-release repo:microsoft/vscode-copilot repo:microsoft/vscode-copilot-release repo:microsoft/vscode-js-debug repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-dev repo:microsoft/vscode-unpkg repo:microsoft/vscode-references-view repo:microsoft/vscode-anycode repo:microsoft/vscode-hexeditor repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-livepreview repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-remote-repositories-github repo:microsoft/monaco-editor repo:microsoft/vscode-vsce repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-livepreview repo:microsoft/vscode-livepreview repo:microsoft/vscode-python repo:microsoft/vscode-python-debugger repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-l10n repo:microsoft/vscode-remote-tunnels\n\n$MILESTONE=milestone:\"June 2023\"\n\n$MINE=assignee:@me"
10+
"value": "$REPOS=repo:microsoft/vscode repo:microsoft/vscode-remote-release repo:microsoft/vscode-copilot repo:microsoft/vscode-copilot-release repo:microsoft/vscode-js-debug repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-dev repo:microsoft/vscode-unpkg repo:microsoft/vscode-references-view repo:microsoft/vscode-anycode repo:microsoft/vscode-hexeditor repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-livepreview repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-remote-repositories-github repo:microsoft/monaco-editor repo:microsoft/vscode-vsce repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-livepreview repo:microsoft/vscode-livepreview repo:microsoft/vscode-python repo:microsoft/vscode-python-debugger repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-l10n repo:microsoft/vscode-remote-tunnels\n\n$MILESTONE=milestone:\"July 2023\"\n\n$MINE=assignee:@me"
1111
},
1212
{
1313
"kind": 1,

.vscode/notebooks/verification.github-issues

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
{
1313
"kind": 2,
1414
"language": "github-issues",
15-
"value": "$repos=repo:microsoft/vscode repo:microsoft/vscode-remote-release repo:microsoft/vscode-js-debug repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-dev repo:microsoft/vscode-unpkg repo:microsoft/vscode-references-view repo:microsoft/vscode-anycode repo:microsoft/vscode-hexeditor repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-livepreview repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-remote-repositories-github repo:microsoft/monaco-editor repo:microsoft/vscode-vsce repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-livepreview repo:microsoft/vscode-livepreview repo:microsoft/vscode-python repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-l10n repo:microsoft/vscode-remote-tunnels\n$milestone=milestone:\"June 2023\""
15+
"value": "$repos=repo:microsoft/vscode repo:microsoft/vscode-remote-release repo:microsoft/vscode-js-debug repo:microsoft/vscode-pull-request-github repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-internalbacklog repo:microsoft/vscode-dev repo:microsoft/vscode-unpkg repo:microsoft/vscode-references-view repo:microsoft/vscode-anycode repo:microsoft/vscode-hexeditor repo:microsoft/vscode-extension-telemetry repo:microsoft/vscode-livepreview repo:microsoft/vscode-remotehub repo:microsoft/vscode-settings-sync-server repo:microsoft/vscode-remote-repositories-github repo:microsoft/monaco-editor repo:microsoft/vscode-vsce repo:microsoft/vscode-dev-chrome-launcher repo:microsoft/vscode-emmet-helper repo:microsoft/vscode-livepreview repo:microsoft/vscode-livepreview repo:microsoft/vscode-python repo:microsoft/vscode-jupyter repo:microsoft/vscode-jupyter-internal repo:microsoft/vscode-github-issue-notebooks repo:microsoft/vscode-l10n repo:microsoft/vscode-remote-tunnels\n$milestone=milestone:\"July 2023\""
1616
},
1717
{
1818
"kind": 1,

.vscode/notebooks/vscode-dev.github-issues

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
{
33
"kind": 2,
44
"language": "github-issues",
5-
"value": "$milestone=milestone:\"June 2023\""
5+
"value": "$milestone=milestone:\"July 2023\""
66
},
77
{
88
"kind": 1,

src/vs/editor/browser/widget/codeEditorWidget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1308,7 +1308,7 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE
13081308
for (const decorationOption of decorationOptions) {
13091309
let typeKey = decorationTypeKey;
13101310
if (decorationOption.renderOptions) {
1311-
// identify custom reder options by a hash code over all keys and values
1311+
// identify custom render options by a hash code over all keys and values
13121312
// For custom render options register a decoration type if necessary
13131313
const subType = hash(decorationOption.renderOptions).toString(16);
13141314
// The fact that `decorationTypeKey` appears in the typeKey has no influence

src/vs/editor/common/core/cursorColumns.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,15 +116,15 @@ export class CursorColumns {
116116
}
117117

118118
/**
119-
* ATTENTION: This works with 0-based columns (as oposed to the regular 1-based columns)
119+
* ATTENTION: This works with 0-based columns (as opposed to the regular 1-based columns)
120120
* @see {@link CursorColumns}
121121
*/
122122
public static nextRenderTabStop(visibleColumn: number, tabSize: number): number {
123123
return visibleColumn + tabSize - visibleColumn % tabSize;
124124
}
125125

126126
/**
127-
* ATTENTION: This works with 0-based columns (as oposed to the regular 1-based columns)
127+
* ATTENTION: This works with 0-based columns (as opposed to the regular 1-based columns)
128128
* @see {@link CursorColumns}
129129
*/
130130
public static nextIndentTabStop(visibleColumn: number, indentSize: number): number {

src/vs/platform/secrets/common/secrets.ts

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { SequencerByKey } from 'vs/base/common/async';
77
import { IEncryptionService } from 'vs/platform/encryption/common/encryptionService';
88
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
99
import { IStorageService, InMemoryStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage';
10-
import { Event, PauseableEmitter } from 'vs/base/common/event';
10+
import { Emitter, Event } from 'vs/base/common/event';
1111
import { ILogService } from 'vs/platform/log/common/log';
1212
import { IDisposable } from 'vs/base/common/lifecycle';
1313

@@ -30,7 +30,7 @@ export abstract class BaseSecretStorageService implements ISecretStorageService
3030

3131
private _storagePrefix = 'secret://';
3232

33-
private readonly _onDidChangeSecret = new PauseableEmitter<string>();
33+
private readonly _onDidChangeSecret = new Emitter<string>();
3434
onDidChangeSecret: Event<string> = this._onDidChangeSecret.event;
3535

3636
protected readonly _sequencer = new SequencerByKey<string>();
@@ -55,11 +55,6 @@ export abstract class BaseSecretStorageService implements ISecretStorageService
5555
return;
5656
}
5757

58-
if (this._onDidChangeSecret.isPaused) {
59-
this._logService.trace(`[SecretStorageService] Skipping change event for secret: ${key} because it is paused`);
60-
return;
61-
}
62-
6358
const secretKey = key.slice(this._storagePrefix.length);
6459

6560
this._logService.trace(`[SecretStorageService] Notifying change in value for secret: ${secretKey}`);
@@ -104,13 +99,8 @@ export abstract class BaseSecretStorageService implements ISecretStorageService
10499
throw e;
105100
}
106101
const fullKey = this.getKey(key);
107-
try {
108-
this._onDidChangeSecret.pause();
109-
this._logService.trace('[secrets] storing encrypted secret for key:', fullKey);
110-
storageService.store(fullKey, encrypted, StorageScope.APPLICATION, StorageTarget.MACHINE);
111-
} finally {
112-
this._onDidChangeSecret.resume();
113-
}
102+
this._logService.trace('[secrets] storing encrypted secret for key:', fullKey);
103+
storageService.store(fullKey, encrypted, StorageScope.APPLICATION, StorageTarget.MACHINE);
114104
this._logService.trace('[secrets] stored encrypted secret for key:', fullKey);
115105
});
116106
}
@@ -120,13 +110,8 @@ export abstract class BaseSecretStorageService implements ISecretStorageService
120110
const storageService = await this.resolvedStorageService;
121111

122112
const fullKey = this.getKey(key);
123-
try {
124-
this._onDidChangeSecret.pause();
125-
this._logService.trace('[secrets] deleting secret for key:', fullKey);
126-
storageService.remove(fullKey, StorageScope.APPLICATION);
127-
} finally {
128-
this._onDidChangeSecret.resume();
129-
}
113+
this._logService.trace('[secrets] deleting secret for key:', fullKey);
114+
storageService.remove(fullKey, StorageScope.APPLICATION);
130115
this._logService.trace('[secrets] deleted secret for key:', fullKey);
131116
});
132117
}

src/vs/workbench/api/common/extHostInlineChat.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import * as extHostTypes from 'vs/workbench/api/common/extHostTypes';
1717
import type * as vscode from 'vscode';
1818
import { ApiCommand, ApiCommandArgument, ApiCommandResult, ExtHostCommands } from 'vs/workbench/api/common/extHostCommands';
1919
import { IRange } from 'vs/editor/common/core/range';
20+
import { IPosition } from 'vs/editor/common/core/position';
2021

2122
class ProviderWrapper {
2223

@@ -59,12 +60,14 @@ export class ExtHostInteractiveEditor implements ExtHostInlineChatShape {
5960
initialRange?: vscode.Range;
6061
message?: string;
6162
autoSend?: boolean;
63+
position?: vscode.Position;
6264
};
6365

6466
type InteractiveEditorRunOptions = {
6567
initialRange?: IRange;
6668
message?: string;
6769
autoSend?: boolean;
70+
position?: IPosition;
6871
};
6972

7073
extHostCommands.registerApiCommand(new ApiCommand(
@@ -78,7 +81,8 @@ export class ExtHostInteractiveEditor implements ExtHostInlineChatShape {
7881
return {
7982
initialRange: v.initialRange ? typeConvert.Range.from(v.initialRange) : undefined,
8083
message: v.message,
81-
autoSend: v.autoSend
84+
autoSend: v.autoSend,
85+
position: v.position ? typeConvert.Position.from(v.position) : undefined,
8286
};
8387
})],
8488
ApiCommandResult.Void

0 commit comments

Comments
 (0)