release/1.88 fix: incorrectly gives console error (microsoft#208984)

justschen · web-flow · commit 62f69a373ed1 · 2024-03-28T14:07:24.000-07:00
* add candidate fix

* use ext identifier instead
diff --git a/src/vs/workbench/services/issue/electron-sandbox/issueService.ts b/src/vs/workbench/services/issue/electron-sandbox/issueService.ts
@@ -186,7 +186,7 @@ export class NativeIssueService implements IWorkbenchIssueService {
 		}, dataOverrides);
 
 		if (issueReporterData.extensionId) {
-			const extensionExists = extensionData.some(extension => extension.id === issueReporterData.extensionId);
+			const extensionExists = extensionData.some(extension => ExtensionIdentifier.equals(extension.id, issueReporterData.extensionId));
 			if (!extensionExists) {
 				console.error(`Extension with ID ${issueReporterData.extensionId} does not exist.`);
 			}

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ export class NativeIssueService implements IWorkbenchIssueService {`
`186`	`186`	`}, dataOverrides);`
`187`	`187`
`188`	`188`	`if (issueReporterData.extensionId) {`
`189`		`- const extensionExists = extensionData.some(extension => extension.id === issueReporterData.extensionId);`
	`189`	`+ const extensionExists = extensionData.some(extension => ExtensionIdentifier.equals(extension.id, issueReporterData.extensionId));`
`190`	`190`	`if (!extensionExists) {`
`191`	`191`	console.error(`Extension with ID ${issueReporterData.extensionId} does not exist.`);
`192`	`192`	`}`