Replace editor.hover.below with editor.hover.above and have rendering below be the new default (microsoft#30797)

Author: alexdima

src/vs/editor/common/config/editorOptions.ts

@@ -1777,10 +1777,10 @@ export interface IEditorHoverOptions {
 	 */
 	sticky?: boolean;
 	/**
-	 * Should the hover be shown below the line if possible?
+	 * Should the hover be shown above the line if possible?
 	 * Defaults to false.
 	 */
-	below?: boolean;
+	above?: boolean;
 }
 
 /**
@@ -1795,7 +1795,7 @@ class EditorHover extends BaseEditorOption<EditorOption.hover, EditorHoverOption
 			enabled: true,
 			delay: 300,
 			sticky: true,
-			below: false,
+			above: false,
 		};
 		super(
 			EditorOption.hover, 'hover', defaults,
@@ -1815,10 +1815,10 @@ class EditorHover extends BaseEditorOption<EditorOption.hover, EditorHoverOption
 					default: defaults.sticky,
 					description: nls.localize('hover.sticky', "Controls whether the hover should remain visible when mouse is moved over it.")
 				},
-				'editor.hover.below': {
+				'editor.hover.above': {
 					type: 'boolean',
-					default: defaults.below,
-					description: nls.localize('hover.below', "Show hovers below the line instead of above, if there's space.")
+					default: defaults.above,
+					description: nls.localize('hover.above', "Prefer showing hovers above the line, if there's space.")
 				},
 			}
 		);
@@ -1833,7 +1833,7 @@ class EditorHover extends BaseEditorOption<EditorOption.hover, EditorHoverOption
 			enabled: boolean(input.enabled, this.defaultValue.enabled),
 			delay: EditorIntOption.clampedInt(input.delay, this.defaultValue.delay, 0, 10000),
 			sticky: boolean(input.sticky, this.defaultValue.sticky),
-			below: boolean(input.below, this.defaultValue.below),
+			above: boolean(input.above, this.defaultValue.above),
 		};
 	}
 }

src/vs/editor/contrib/hover/modesContentHover.ts

@@ -27,9 +27,10 @@ import { HoverAnchor, HoverAnchorType, HoverRangeAnchor, IEditorHover, IEditorHo
 import { MarkdownHoverParticipant } from 'vs/editor/contrib/hover/markdownHoverParticipant';
 import { MarkerHoverParticipant } from 'vs/editor/contrib/hover/markerHoverParticipant';
 import { InlineCompletionsHoverParticipant } from 'vs/editor/contrib/inlineCompletions/inlineCompletionsHoverParticipant';
-import { IContextKey } from 'vs/platform/contextkey/common/contextkey';
+import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
 import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
+import { Context as SuggestContext } from 'vs/editor/contrib/suggest/suggest';
 
 const $ = dom.$;
 
@@ -199,13 +200,14 @@ export class ModesContentHoverWidget extends Widget implements IContentWidget, I
 	private _shouldFocus: boolean;
 	private _colorPicker: ColorPickerWidget | null;
 	private _renderDisposable: IDisposable | null;
-	private _preferBelow: boolean;
+	private _preferAbove: boolean;
 
 	constructor(
 		editor: ICodeEditor,
 		private readonly _hoverVisibleKey: IContextKey<boolean>,
 		@IInstantiationService instantiationService: IInstantiationService,
 		@IKeybindingService private readonly _keybindingService: IKeybindingService,
+		@IContextKeyService private readonly _contextKeyService: IContextKeyService,
 	) {
 		super();
 
@@ -251,7 +253,7 @@ export class ModesContentHoverWidget extends Widget implements IContentWidget, I
 		this._isChangingDecorations = false;
 		this._shouldFocus = false;
 		this._colorPicker = null;
-		this._preferBelow = this._editor.getOption(EditorOption.hover).below;
+		this._preferAbove = this._editor.getOption(EditorOption.hover).above;
 
 		this._hoverOperation = new HoverOperation(
 			this._computer,
@@ -271,7 +273,7 @@ export class ModesContentHoverWidget extends Widget implements IContentWidget, I
 		}));
 		this._register(editor.onDidChangeConfiguration(() => {
 			this._hoverOperation.setHoverTime(this._editor.getOption(EditorOption.hover).delay);
-			this._preferBelow = this._editor.getOption(EditorOption.hover).below;
+			this._preferAbove = this._editor.getOption(EditorOption.hover).above;
 		}));
 		this._register(TokenizationRegistry.onDidChange(() => {
 			if (this._isVisible && this._lastAnchor && this._messages.length > 0) {
@@ -368,15 +370,20 @@ export class ModesContentHoverWidget extends Widget implements IContentWidget, I
 
 	public getPosition(): IContentWidgetPosition | null {
 		if (this._isVisible) {
+			let preferAbove = this._preferAbove;
+			if (!preferAbove && this._contextKeyService.getContextKeyValue<boolean>(SuggestContext.Visible.key)) {
+				// Prefer rendering above if the suggest widget is visible
+				preferAbove = true;
+			}
 			return {
 				position: this._showAtPosition,
 				range: this._showAtRange,
-				preference: this._preferBelow ? [
-					ContentWidgetPositionPreference.BELOW,
+				preference: preferAbove ? [
 					ContentWidgetPositionPreference.ABOVE,
+					ContentWidgetPositionPreference.BELOW,
 				] : [
-					ContentWidgetPositionPreference.ABOVE,
 					ContentWidgetPositionPreference.BELOW,
+					ContentWidgetPositionPreference.ABOVE,
 				],
 			};
 		}

src/vs/monaco.d.ts

@@ -3511,10 +3511,10 @@ declare namespace monaco.editor {
 		 */
 		sticky?: boolean;
 		/**
-		 * Should the hover be shown below the line if possible?
+		 * Should the hover be shown above the line if possible?
 		 * Defaults to false.
 		 */
-		below?: boolean;
+		above?: boolean;
 	}
 
 	/**