re-add check for isDisposed

meganrogge · meganrogge · commit 65400a176931 · 2023-05-18T11:29:50.000-07:00
diff --git a/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts b/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts
@@ -1327,7 +1327,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {
 			return;
 		}
 		this._reconnectedTerminals = [];
-		for (const terminal of this._terminalService.getReconnectedTerminals(ReconnectionType) || []) {
+		for (const terminal of this._terminalService.getReconnectedTerminals(ReconnectionType)?.filter(t => !t.isDisposed) || []) {
 			const reconnectionData = terminal.shellLaunchConfig.attachPersistentProcess?.reconnectionProperties?.data as IReconnectionTaskData;
 			if (reconnectionData) {
 				this._reconnectedTerminals.push({ ...terminal, reconnectionData });

Original file line number	Diff line number	Diff line change
`@@ -1327,7 +1327,7 @@ export class TerminalTaskSystem extends Disposable implements ITaskSystem {`
`1327`	`1327`	`return;`
`1328`	`1328`	`}`
`1329`	`1329`	`this._reconnectedTerminals = [];`
`1330`		`- for (const terminal of this._terminalService.getReconnectedTerminals(ReconnectionType) \|\| []) {`
	`1330`	`+ for (const terminal of this._terminalService.getReconnectedTerminals(ReconnectionType)?.filter(t => !t.isDisposed) \|\| []) {`
`1331`	`1331`	`const reconnectionData = terminal.shellLaunchConfig.attachPersistentProcess?.reconnectionProperties?.data as IReconnectionTaskData;`
`1332`	`1332`	`if (reconnectionData) {`
`1333`	`1333`	`this._reconnectedTerminals.push({ ...terminal, reconnectionData });`