Skip to content

Commit 65b2188

Browse files
committed
Removing the check on top and bottom which are not needed
1 parent 29f37cc commit 65b2188

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/vs/editor/contrib/colorPicker/browser/colorPickerWidget.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,11 @@ import { IThemeService } from 'vs/platform/theme/common/themeService';
2222

2323
const $ = dom.$;
2424

25-
function elementsOverlap(el1: HTMLElement, el2: HTMLElement) {
25+
function elementsOverlapHorizontally(el1: HTMLElement, el2: HTMLElement) {
2626
const domRect1 = el1.getBoundingClientRect();
2727
const domRect2 = el2.getBoundingClientRect();
2828
return !(
29-
domRect1.top > domRect2.bottom ||
3029
domRect1.right < domRect2.left ||
31-
domRect1.bottom < domRect2.top ||
3230
domRect1.left > domRect2.right
3331
);
3432
}
@@ -83,7 +81,7 @@ export class ColorPickerHeader extends Disposable {
8381

8482
const resizeObserver = new ResizeObserver(() => {
8583
this._pickedColorRepresentation.style.display = 'block';
86-
if (elementsOverlap(this._pickedColorRepresentation, icon)) {
84+
if (elementsOverlapHorizontally(this._pickedColorRepresentation, icon)) {
8785
this._pickedColorRepresentation.style.display = 'none';
8886
} else {
8987
this._pickedColorRepresentation.style.display = 'block';

0 commit comments

Comments
 (0)