Skip to content

Commit 675806f

Browse files
committed
The TestTextFileEditor doesn't use editor contribution anymore.
This is because not every test disposes its code editors correctly and leaking contributions (like the `FoldingController`) have weird side-effects (still listening etc). Also, tests at the workbench level don't need editor contribution and editor construction is faster without them fyi @bpasero
1 parent 59e8b5f commit 675806f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/vs/workbench/test/browser/workbenchTestServices.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ export class TestTextResourceEditor extends TextResourceEditor {
194194
export class TestTextFileEditor extends TextFileEditor {
195195

196196
protected override createEditorControl(parent: HTMLElement, configuration: any): void {
197-
this.editorControl = this.instantiationService.createInstance(TestCodeEditor, parent, configuration, {});
197+
this.editorControl = this.instantiationService.createInstance(TestCodeEditor, parent, configuration, { contributions: [] });
198198
}
199199

200200
setSelection(selection: Selection | undefined, reason: EditorPaneSelectionChangeReason): void {

0 commit comments

Comments
 (0)