Skip to content

Commit 681256b

Browse files
committed
1 parent 7df05a7 commit 681256b

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/vs/workbench/api/browser/mainThreadTask.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { generateUuid } from 'vs/base/common/uuid';
1010
import * as Types from 'vs/base/common/types';
1111
import * as Platform from 'vs/base/common/platform';
1212
import { IStringDictionary } from 'vs/base/common/collections';
13-
import { IDisposable } from 'vs/base/common/lifecycle';
13+
import { Disposable, IDisposable } from 'vs/base/common/lifecycle';
1414

1515
import { IWorkspace, IWorkspaceContextService, IWorkspaceFolder } from 'vs/platform/workspace/common/workspace';
1616

@@ -414,7 +414,7 @@ namespace TaskFilterDTO {
414414
}
415415

416416
@extHostNamedCustomer(MainContext.MainThreadTask)
417-
export class MainThreadTask implements MainThreadTaskShape {
417+
export class MainThreadTask extends Disposable implements MainThreadTaskShape {
418418

419419
private readonly _extHostContext: IExtHostContext | undefined;
420420
private readonly _proxy: ExtHostTaskShape;
@@ -426,9 +426,10 @@ export class MainThreadTask implements MainThreadTaskShape {
426426
@IWorkspaceContextService private readonly _workspaceContextServer: IWorkspaceContextService,
427427
@IConfigurationResolverService private readonly _configurationResolverService: IConfigurationResolverService
428428
) {
429+
super();
429430
this._proxy = extHostContext.getProxy(ExtHostContext.ExtHostTask);
430431
this._providers = new Map();
431-
this._taskService.onDidStateChange(async (event: ITaskEvent) => {
432+
this._register(this._taskService.onDidStateChange(async (event: ITaskEvent) => {
432433
if (event.kind === TaskEventKind.Changed) {
433434
return;
434435
}
@@ -453,14 +454,15 @@ export class MainThreadTask implements MainThreadTaskShape {
453454
} else if (event.kind === TaskEventKind.End) {
454455
this._proxy.$OnDidEndTask(TaskExecutionDTO.from(task.getTaskExecution()));
455456
}
456-
});
457+
}));
457458
}
458459

459-
public dispose(): void {
460+
public override dispose(): void {
460461
for (const value of this._providers.values()) {
461462
value.disposable.dispose();
462463
}
463464
this._providers.clear();
465+
super.dispose();
464466
}
465467

466468
$createTaskId(taskDTO: ITaskDTO): Promise<string> {

0 commit comments

Comments
 (0)