Generate activation event automatically

Author: mjbvz

src/vs/workbench/contrib/chat/browser/chatOutputItemRenderer.ts

@@ -13,7 +13,6 @@ import { generateUuid } from '../../../../base/common/uuid.js';
 import * as nls from '../../../../nls.js';
 import { ExtensionIdentifier } from '../../../../platform/extensions/common/extensions.js';
 import { createDecorator } from '../../../../platform/instantiation/common/instantiation.js';
-import { ILogService } from '../../../../platform/log/common/log.js';
 import { IWebview, IWebviewService, WebviewContentPurpose } from '../../../contrib/webview/browser/webview.js';
 import { IExtensionService } from '../../../services/extensions/common/extensions.js';
 import { ExtensionsRegistry } from '../../../services/extensions/common/extensionsRegistry.js';
@@ -52,17 +51,14 @@ export class ChatOutputRendererService extends Disposable implements IChatOutput
 	}>();
 
 	constructor(
-		@ILogService private readonly _logService: ILogService,
 		@IWebviewService private readonly _webviewService: IWebviewService,
 		@IExtensionService private readonly _extensionService: IExtensionService,
 	) {
 		super();
-		this._logService.debug('ChatOutputItemRendererService: Created');
 	}
 
 	registerRenderer(mime: string, renderer: IChatOutputItemRenderer, options: RegisterOptions): IDisposable {
 		this._renderers.set(mime, { renderer, options });
-		this._logService.debug(`ChatOutputItemRendererService: Registered renderer for MIME type ${mime}`);
 		return {
 			dispose: () => {
 				this._renderers.delete(mime);
@@ -120,6 +116,13 @@ interface IChatOutputRendererContribution {
 
 ExtensionsRegistry.registerExtensionPoint<IChatOutputRendererContribution[]>({
 	extensionPoint: 'chatOutputRenderer',
+	activationEventsGenerator: (contributions: IChatOutputRendererContribution[], result) => {
+		for (const contrib of contributions) {
+			for (const mime of contrib.mimeTypes) {
+				result.push(`onChatOutputRenderer:${mime}`);
+			}
+		}
+	},
 	jsonSchema: {
 		description: nls.localize('vscode.extension.contributes.chatOutputRenderer', 'Contributes a renderer for specific MIME types in chat outputs'),
 		type: 'array',
@@ -139,5 +142,3 @@ ExtensionsRegistry.registerExtensionPoint<IChatOutputRendererContribution[]>({
 		}
 	}
 });
-
-

src/vscode-dts/vscode.proposed.chatOutputRenderer.d.ts

@@ -49,9 +49,18 @@ declare module 'vscode' {
 		/**
 		 * Registers a new renderer for a given mime type.
 		 *
-		 * Note: make sure to use the `onChatOutputRenderer:mime` activation event in your extension's `package.json` to ensure that the renderer is registered.
+		 * Note: To use this API, you should also add a contribution point in your extension's
+		 * package.json:
 		 *
-		 * TODO:should this be a contribution instead?
+		 * ```json
+		 * "contributes": {
+		 *   "chatOutputRenderer": [
+		 *     {
+		 *       "mimeTypes": ["application/your-mime-type"]
+		 *     }
+		 *   ]
+		 * }
+		 * ```
 		 *
 		 * @param mime The MIME type of the output that this renderer can handle.
 		 * @param renderer The renderer to register.