Skip to content

Commit 6a805df

Browse files
committed
refine async edits telemetry
1 parent b8f0cf3 commit 6a805df

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/vs/editor/contrib/suggest/browser/suggestController.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ export class SuggestController implements IEditorContribution {
379379

380380
tasks.push(item.resolve(cts.token).then(() => {
381381
if (!item.completion.additionalTextEdits || cts.token.isCancellationRequested) {
382-
return false;
382+
return undefined;
383383
}
384384
if (position && item.completion.additionalTextEdits.some(edit => Position.isBefore(position!, Range.getStartPosition(edit.range)))) {
385385
return false;
@@ -406,10 +406,12 @@ export class SuggestController implements IEditorContribution {
406406
providerId: { classification: 'PublicNonPersonalData'; purpose: 'FeatureInsight'; comment: 'Provider of the completions item' };
407407
applied: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'If async additional text edits could be applied' };
408408
};
409-
this._telemetryService.publicLog2<AsyncSuggestEdits, AsyncSuggestEditsClassification>('suggest.asyncAdditionalEdits', {
410-
providerId: item.extensionId?.value ?? 'unknown',
411-
applied
412-
});
409+
if (typeof applied === 'boolean') {
410+
this._telemetryService.publicLog2<AsyncSuggestEdits, AsyncSuggestEditsClassification>('suggest.asyncAdditionalEdits', {
411+
providerId: item.extensionId?.value ?? 'unknown',
412+
applied
413+
});
414+
}
413415
}).finally(() => {
414416
docListener.dispose();
415417
typeListener.dispose();

0 commit comments

Comments
 (0)