Skip to content

Commit 6b83d6d

Browse files
authored
testing: use overflow ellipsis in test tree (microsoft#186806)
* tree: add fast path for children updates in compressedObjectTreeModel I noticed in testing that more things were getting rerendered than they should have been. This adds a fast path so that, if the elements in a compressed node don't change when its children are updated, we only update the children instead of replacing the entire node from the parent collection. * testing: use overflow ellipsis in test tree Fixes microsoft#186320 Had to abandon flexbox for this, so do manual tweaks to make codicons show nicely: ![](https://memes.peet.io/img/23-06-321bf892-8f69-4548-9c76-465f33205c8e.png)
1 parent 01d4949 commit 6b83d6d

File tree

1 file changed

+9
-12
lines changed
  • src/vs/workbench/contrib/testing/browser/media

1 file changed

+9
-12
lines changed

src/vs/workbench/contrib/testing/browser/media/testing.css

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,19 @@
4343

4444
.test-explorer .test-item .label,
4545
.test-output-peek-tree .test-peek-item .name {
46-
display: flex;
47-
align-items: center;
4846
flex-grow: 1;
49-
gap: 0.15em;
5047
width: 0;
5148
overflow: hidden;
5249
white-space: nowrap;
50+
text-overflow: ellipsis;
51+
}
52+
53+
.test-output-peek-tree .test-peek-item .name .codicon,
54+
.test-explorer .test-item .label .codicon {
55+
vertical-align: middle;
56+
font-size: 1em;
57+
transform: scale(1.25);
58+
margin: 0 0.125em;
5359
}
5460

5561
.test-explorer .test-item,
@@ -108,15 +114,6 @@
108114
margin: 0;
109115
}
110116

111-
.test-explorer .name,
112-
.test-output-peek-tree .name {
113-
overflow: hidden;
114-
text-overflow: ellipsis;
115-
flex-grow: 1;
116-
height: 22px;
117-
align-items: center;
118-
}
119-
120117
.test-explorer .computed-state,
121118
.test-output-peek-tree .computed-state {
122119
margin-right: 0.25em;

0 commit comments

Comments
 (0)