Skip to content

Commit 6c3e1f0

Browse files
authored
Pick up latest notebook renderer API typings (microsoft#161135)
1 parent 687712b commit 6c3e1f0

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@
116116
"@types/sinon": "^10.0.2",
117117
"@types/sinon-test": "^2.4.2",
118118
"@types/trusted-types": "^1.0.6",
119-
"@types/vscode-notebook-renderer": "^1.60.0",
119+
"@types/vscode-notebook-renderer": "^1.72.0",
120120
"@types/webpack": "^4.41.25",
121121
"@types/wicg-file-system-access": "^2020.9.5",
122122
"@types/windows-foreground-love": "^0.3.0",

src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1373,10 +1373,6 @@ async function webviewPreloads(ctx: PreloadContext) {
13731373
}
13741374
};
13751375

1376-
type ExtendedRendererApi = rendererApi.RendererApi & {
1377-
renderOutputItem(outputItem: rendererApi.OutputItem, element: HTMLElement, signal: AbortSignal): void | Promise<void>;
1378-
};
1379-
13801376
const renderers = new class {
13811377
private readonly _renderers = new Map</* id */ string, Renderer>();
13821378

@@ -1490,7 +1486,7 @@ async function webviewPreloads(ctx: PreloadContext) {
14901486

14911487
const renderer = await renderers[0].load();
14921488
if (renderer) {
1493-
await (renderer as ExtendedRendererApi).renderOutputItem(info, element, signal);
1489+
await renderer.renderOutputItem(info, element, signal);
14941490
}
14951491
}
14961492
}();
@@ -2139,7 +2135,7 @@ async function webviewPreloads(ctx: PreloadContext) {
21392135
const errors = preloadsAndErrors.filter((e): e is Error => e instanceof Error);
21402136
showPreloadErrors(this.element, ...errors);
21412137
} else {
2142-
const rendererApi = preloadsAndErrors[0] as ExtendedRendererApi;
2138+
const rendererApi = preloadsAndErrors[0] as rendererApi.RendererApi;
21432139
try {
21442140
const item = createOutputItem(this.outputId, content.mimeType, content.metadata, content.valueBytes);
21452141

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1091,10 +1091,10 @@
10911091
"@types/expect" "^1.20.4"
10921092
"@types/node" "*"
10931093

1094-
"@types/vscode-notebook-renderer@^1.60.0":
1095-
version "1.60.0"
1096-
resolved "https://registry.yarnpkg.com/@types/vscode-notebook-renderer/-/vscode-notebook-renderer-1.60.0.tgz#8a67d561f48ddf46a95dfa9f712a79c72c7b8f7a"
1097-
integrity sha512-u7TD2uuEZTVuitx0iijOJdKI0JLiQP6PsSBSRy2XmHXUOXcp5p1S56NrjOEDoF+PIHd3NL3eO6KTRSf5nukDqQ==
1094+
"@types/vscode-notebook-renderer@^1.72.0":
1095+
version "1.72.0"
1096+
resolved "https://registry.yarnpkg.com/@types/vscode-notebook-renderer/-/vscode-notebook-renderer-1.72.0.tgz#8943dc3cef0ced2dfb1e04c0a933bd289e7d5199"
1097+
integrity sha512-5iTjb39DpLn03ULUwrDR3L2Dy59RV4blSUHy0oLdQuIY11PhgWO4mXIcoFS0VxY1GZQ4IcjSf3ooT2Jrrcahnw==
10981098

10991099
"@types/webpack-sources@*":
11001100
version "2.1.0"

0 commit comments

Comments
 (0)