Skip to content

Commit 6c8cdf3

Browse files
authored
Remove galleryExtension check when initializing remote menu (microsoft#187109)
Remove galleryExtension check
1 parent 609e636 commit 6c8cdf3

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

src/vs/workbench/contrib/remote/browser/remoteIndicator.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ import { IProductService } from 'vs/platform/product/common/productService';
4747
import { DomEmitter } from 'vs/base/browser/event';
4848
import { registerColor } from 'vs/platform/theme/common/colorRegistry';
4949
import { ExtensionIdentifier } from 'vs/platform/extensions/common/extensions';
50-
import { CancellationToken, CancellationTokenSource } from 'vs/base/common/cancellation';
50+
import { CancellationToken } from 'vs/base/common/cancellation';
5151
import { ThemeIcon } from 'vs/base/common/themables';
5252
import { infoIcon } from 'vs/workbench/contrib/extensions/browser/extensionsIcons';
5353
import { IOpenerService } from 'vs/platform/opener/common/opener';
@@ -325,22 +325,18 @@ export class RemoteStatusIndicator extends Disposable implements IWorkbenchContr
325325
for (let i = 0; i < this.remoteExtensionMetadata.length; i++) {
326326
const extensionId = this.remoteExtensionMetadata[i].id;
327327
const supportedPlatforms = this.remoteExtensionMetadata[i].supportedPlatforms;
328-
// Update compatibility
329-
const token = new CancellationTokenSource();
330-
const galleryExtension = (await this.extensionGalleryService.getExtensions([{ id: extensionId }], token.token))[0];
331-
if (!await this.extensionManagementService.canInstall(galleryExtension)) {
332-
this.remoteExtensionMetadata[i].isPlatformCompatible = false;
328+
const isInstalled = (await this.extensionManagementService.getInstalled()).find(value => ExtensionIdentifier.equals(value.identifier.id, extensionId)) ? true : false;
329+
330+
this.remoteExtensionMetadata[i].installed = isInstalled;
331+
if (isInstalled) {
332+
this.remoteExtensionMetadata[i].isPlatformCompatible = true;
333333
}
334334
else if (supportedPlatforms && !supportedPlatforms.includes(currentPlatform)) {
335335
this.remoteExtensionMetadata[i].isPlatformCompatible = false;
336336
}
337337
else {
338338
this.remoteExtensionMetadata[i].isPlatformCompatible = true;
339-
this.remoteExtensionMetadata[i].dependencies = galleryExtension.properties.extensionPack ?? [];
340339
}
341-
342-
// Check if installed and enabled
343-
this.remoteExtensionMetadata[i].installed = (await this.extensionManagementService.getInstalled()).find(value => ExtensionIdentifier.equals(value.identifier.id, extensionId)) ? true : false;
344340
}
345341

346342
this.remoteMetadataInitialized = true;

0 commit comments

Comments
 (0)