edit requests onExp and added telemetry (microsoft#252922)

* add telemetry and switch setting to exp

* fix names

* change to onExp

* clean up telemetry call

* change telemetry name again

Author: justschen

src/vs/workbench/contrib/chat/browser/actions/chatExecuteActions.ts

@@ -20,6 +20,7 @@ import { ContextKeyExpr, IContextKeyService } from '../../../../../platform/cont
 import { IDialogService } from '../../../../../platform/dialogs/common/dialogs.js';
 import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
 import { KeybindingWeight } from '../../../../../platform/keybinding/common/keybindingsRegistry.js';
+import { ITelemetryService } from '../../../../../platform/telemetry/common/telemetry.js';
 import { IRemoteCodingAgentsService } from '../../../remoteCodingAgents/common/remoteCodingAgentsService.js';
 import { IChatAgentHistoryEntry, IChatAgentService } from '../../common/chatAgents.js';
 import { ChatContextKeys } from '../../common/chatContextKeys.js';
@@ -48,7 +49,7 @@ export interface IChatExecuteActionContext {
 abstract class SubmitAction extends Action2 {
 	async run(accessor: ServicesAccessor, ...args: any[]) {
 		const context: IChatExecuteActionContext | undefined = args[0];
-
+		const telemetryService = accessor.get(ITelemetryService);
 		const widgetService = accessor.get(IChatWidgetService);
 		const widget = context?.widget ?? widgetService.lastFocusedWidget;
 		if (widget?.viewModel?.editing) {
@@ -104,8 +105,33 @@ abstract class SubmitAction extends Action2 {
 					})
 					: { confirmed: true };
 
+				type EditUndoEvent = {
+					editRequestType: string;
+					outcome: 'cancelled' | 'applied';
+					editsUndoCount: number;
+				};
+
+				type EditUndoEventClassification = {
+					owner: 'justschen';
+					comment: 'Event used to gain insights into when there are pending changes to undo, and whether edited requests are applied or cancelled.';
+					editRequestType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Current entry point for editing a request.' };
+					outcome: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether the edit was cancelled or applied.' };
+					editsUndoCount: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Number of edits that would be undone.'; 'isMeasurement': true };
+				};
+
 				if (!confirmation.confirmed) {
+					telemetryService.publicLog2<EditUndoEvent, EditUndoEventClassification>('chat.undoEditsConfirmation', {
+						editRequestType: configurationService.getValue<string>('chat.editRequests'),
+						outcome: 'cancelled',
+						editsUndoCount: editsToUndo
+					});
 					return;
+				} else if (editsToUndo > 0) {
+					telemetryService.publicLog2<EditUndoEvent, EditUndoEventClassification>('chat.undoEditsConfirmation', {
+						editRequestType: configurationService.getValue<string>('chat.editRequests'),
+						outcome: 'applied',
+						editsUndoCount: editsToUndo
+					});
 				}
 
 				if (confirmation.checkboxChecked) {

src/vs/workbench/contrib/chat/browser/chat.contribution.ts

@@ -252,7 +252,7 @@ configurationRegistry.registerConfiguration({
 			type: 'string',
 			enum: ['inline', 'hover', 'input', 'none'],
 			default: 'inline',
-			tags: ['experimental'],
+			tags: ['experimental', 'onExp'],
 		},
 		[mcpEnabledSection]: {
 			type: 'boolean',

src/vs/workbench/contrib/chat/browser/chat.ts

@@ -201,7 +201,7 @@ export interface IChatWidget {
 	logInputHistory(): void;
 	acceptInput(query?: string, options?: IChatAcceptInputOptions): Promise<IChatResponseModel | undefined>;
 	startEditing(requestId: string): void;
-	finishedEditing(): void;
+	finishedEditing(completedEdit?: boolean): void;
 	rerunLastRequest(): Promise<void>;
 	setInputPlaceholder(placeholder: string): void;
 	resetInputPlaceholder(): void;

src/vs/workbench/contrib/chat/browser/chatWidget.ts

@@ -1035,6 +1035,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
 				this.input.attachmentModel.addContext(...currentContext);
 			}
 
+
 			// rerenders
 			this.inputPart.dnd.setDisabledOverlay(!isInput);
 			this.input.renderAttachedContext();
@@ -1060,9 +1061,21 @@ export class ChatWidget extends Disposable implements IChatWidget {
 				}));
 			}
 		}
+
+		type StartRequestEvent = { editRequestType: string };
+
+		type StartRequestEventClassification = {
+			owner: 'justschen';
+			comment: 'Event used to gain insights into when edits are being pressed.';
+			editRequestType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Current entry point for editing a request.' };
+		};
+
+		this.telemetryService.publicLog2<StartRequestEvent, StartRequestEventClassification>('chat.startEditingRequests', {
+			editRequestType: this.configurationService.getValue<string>('chat.editRequests'),
+		});
 	}
 
-	finishedEditing(currentRequest?: IChatListItemTemplate | undefined): void {
+	finishedEditing(completedEdit?: boolean): void {
 		// reset states
 		const editedRequest = this.renderer.getTemplateDataForRequestId(this.viewModel?.editing?.id);
 		this.viewModel?.model.setCheckpoint(undefined);
@@ -1096,6 +1109,23 @@ export class ChatWidget extends Disposable implements IChatWidget {
 			this.renderer.updateItemHeightOnRender(editedRequest.currentElement, editedRequest);
 		}
 
+		type CancelRequestEditEvent = {
+			editRequestType: string;
+			editCanceled: boolean;
+		};
+
+		type CancelRequestEventEditClassification = {
+			owner: 'justschen';
+			editRequestType: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Current entry point for editing a request.' };
+			editCanceled: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Indicates whether the edit was canceled.' };
+			comment: 'Event used to gain insights into when edits are being canceled.';
+		};
+
+		this.telemetryService.publicLog2<CancelRequestEditEvent, CancelRequestEventEditClassification>('chat.editRequestsFinished', {
+			editRequestType: this.configurationService.getValue<string>('chat.editRequests'),
+			editCanceled: !completedEdit
+		});
+
 		this.inputPart.focus();
 	}
 
@@ -1631,7 +1661,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
 				});
 
 				if (this.viewModel?.editing) {
-					this.finishedEditing();
+					this.finishedEditing(true);
 				}
 				return result.responseCreatedPromise;
 			}