Don't wait for orphan check when attaching to process

Tyriar · Tyriar · commit 6e286f8cbec0 · 2023-06-24T06:55:54.000-07:00
Fixes microsoft#186069
diff --git a/src/vs/platform/terminal/node/ptyService.ts b/src/vs/platform/terminal/node/ptyService.ts
@@ -747,11 +747,6 @@ class PersistentTerminalProcess extends Disposable {
 	}
 
 	async attach(): Promise<void> {
-		// Something wrong happened if the disconnect runner is not canceled, this likely means
-		// multiple windows attempted to attach.
-		if (!await this._isOrphaned()) {
-			throw new Error(`Cannot attach to persistent process "${this._persistentProcessId}", it is already adopted`);
-		}
 		if (!this._disconnectRunner1.isScheduled() && !this._disconnectRunner2.isScheduled()) {
 			this._logService.warn(`Persistent process "${this._persistentProcessId}": Process had no disconnect runners but was an orphan`);
 		}

Original file line number	Diff line number	Diff line change
`@@ -747,11 +747,6 @@ class PersistentTerminalProcess extends Disposable {`
`747`	`747`	`}`
`748`	`748`
`749`	`749`	`async attach(): Promise<void> {`
`750`		`- // Something wrong happened if the disconnect runner is not canceled, this likely means`
`751`		`- // multiple windows attempted to attach.`
`752`		`- if (!await this._isOrphaned()) {`
`753`		- throw new Error(`Cannot attach to persistent process "${this._persistentProcessId}", it is already adopted`);
`754`		`- }`
`755`	`750`	`if (!this._disconnectRunner1.isScheduled() && !this._disconnectRunner2.isScheduled()) {`
`756`	`751`	this._logService.warn(`Persistent process "${this._persistentProcessId}": Process had no disconnect runners but was an orphan`);
`757`	`752`	`}`