Move common.cli to electron-sandbox (microsoft#158174)

Author: lramos15

src/vs/platform/telemetry/common/commonProperties.ts

@@ -49,8 +49,6 @@ export async function resolveCommonProperties(
 	result['common.nodeArch'] = arch;
 	// __GDPR__COMMON__ "common.product" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
 	result['common.product'] = product || 'desktop';
-	// __GDPR__COMMON__ "common.cli" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
-	result['common.cli'] = !!env['VSCODE_CLI'];
 
 	if (isInternalTelemetry) {
 		// __GDPR__COMMON__ "common.msftInternal" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }

src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts

@@ -40,6 +40,8 @@ export async function resolveWorkbenchCommonProperties(
 	result['common.remoteAuthority'] = cleanRemoteAuthority(remoteAuthority);
 	// __GDPR__COMMON__ "common.sandboxed" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
 	result['common.sandboxed'] = process.sandboxed ? '1' : '0'; // TODO@bpasero remove this property when sandbox is on
+	// __GDPR__COMMON__ "common.cli" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
+	result['common.cli'] = !!process.env['VSCODE_CLI'];
 
 	return result;
 }