Skip to content

Commit 6ef8bb8

Browse files
authored
Adopt l10n for gulp (microsoft#165543)
For microsoft#164438
1 parent 20a4164 commit 6ef8bb8

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

extensions/gulp/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616
"compile": "gulp compile-extension:gulp",
1717
"watch": "gulp watch-extension:gulp"
1818
},
19-
"dependencies": {
20-
"vscode-nls": "^5.2.0"
21-
},
19+
"dependencies": {},
2220
"devDependencies": {
2321
"@types/node": "16.x"
2422
},

extensions/gulp/src/main.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ import * as path from 'path';
77
import * as fs from 'fs';
88
import * as cp from 'child_process';
99
import * as vscode from 'vscode';
10-
import * as nls from 'vscode-nls';
1110

12-
const localize = nls.loadMessageBundle();
1311

1412
type AutoDetect = 'on' | 'off';
1513

@@ -80,8 +78,8 @@ function getOutputChannel(): vscode.OutputChannel {
8078
}
8179

8280
function showError() {
83-
vscode.window.showWarningMessage(localize('gulpTaskDetectError', 'Problem finding gulp tasks. See the output for more information.'),
84-
localize('gulpShowOutput', 'Go to output')).then((choice) => {
81+
vscode.window.showWarningMessage(vscode.l10n.t("Problem finding gulp tasks. See the output for more information."),
82+
vscode.l10n.t("Go to output")).then((choice) => {
8583
if (choice !== undefined) {
8684
_channel.show(true);
8785
}
@@ -256,7 +254,7 @@ class FolderDetector {
256254
if (err.stdout) {
257255
channel.appendLine(err.stdout);
258256
}
259-
channel.appendLine(localize('execFailed', 'Auto detecting gulp for folder {0} failed with error: {1}', this.workspaceFolder.name, err.error ? err.error.toString() : 'unknown'));
257+
channel.appendLine(vscode.l10n.t("Auto detecting gulp for folder {0} failed with error: {1}', this.workspaceFolder.name, err.error ? err.error.toString() : 'unknown"));
260258
showError();
261259
return emptyTasks;
262260
}

extensions/gulp/yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,3 @@
66
version "16.11.6"
77
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.11.6.tgz#6bef7a2a0ad684cf6e90fcfe31cecabd9ce0a3ae"
88
integrity sha512-ua7PgUoeQFjmWPcoo9khiPum3Pd60k4/2ZGXt18sm2Slk0W0xZTqt5Y0Ny1NyBiN1EVQ/+FaF9NcY4Qe6rwk5w==
9-
10-
vscode-nls@^5.2.0:
11-
version "5.2.0"
12-
resolved "https://registry.yarnpkg.com/vscode-nls/-/vscode-nls-5.2.0.tgz#3cb6893dd9bd695244d8a024bdf746eea665cc3f"
13-
integrity sha512-RAaHx7B14ZU04EU31pT+rKz2/zSl7xMsfIZuo8pd+KZO6PXtQmpevpq3vxvWNcrGbdmhM/rr5Uw5Mz+NBfhVng==

0 commit comments

Comments
 (0)