Skip to content

Commit 6fb4786

Browse files
authored
1 parent 566e71b commit 6fb4786

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

src/vs/workbench/contrib/mergeEditor/browser/view/mergeEditor.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,15 @@ export class MergeEditor extends AbstractTextEditor<IMergeEditorViewState> {
199199
const inputModel = await input.resolve();
200200
const model = inputModel.model;
201201

202-
const viewModel = new MergeEditorViewModel(model, this.input1View, this.input2View, this.inputResultView, this.baseView, this.showNonConflictingChanges, this.configurationService);
202+
const viewModel = this.instantiationService.createInstance(
203+
MergeEditorViewModel,
204+
model,
205+
this.input1View,
206+
this.input2View,
207+
this.inputResultView,
208+
this.baseView,
209+
this.showNonConflictingChanges,
210+
);
203211

204212

205213
model.telemetry.reportMergeEditorOpened({

src/vs/workbench/contrib/mergeEditor/browser/view/viewModel.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ import { Disposable } from 'vs/base/common/lifecycle';
88
import { derived, derivedObservableWithWritableCache, IObservable, IReader, ITransaction, observableFromEvent, observableValue, transaction } from 'vs/base/common/observable';
99
import { Range } from 'vs/editor/common/core/range';
1010
import { ScrollType } from 'vs/editor/common/editorCommon';
11+
import { localize } from 'vs/nls';
1112
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
13+
import { INotificationService } from 'vs/platform/notification/common/notification';
1214
import { LineRange } from 'vs/workbench/contrib/mergeEditor/browser/model/lineRange';
1315
import { MergeEditorModel } from 'vs/workbench/contrib/mergeEditor/browser/model/mergeEditorModel';
1416
import { ModifiedBaseRange, ModifiedBaseRangeState } from 'vs/workbench/contrib/mergeEditor/browser/model/modifiedBaseRange';
@@ -29,7 +31,8 @@ export class MergeEditorViewModel extends Disposable {
2931
public readonly resultCodeEditorView: ResultCodeEditorView,
3032
public readonly baseCodeEditorView: IObservable<BaseCodeEditorView | undefined>,
3133
public readonly showNonConflictingChanges: IObservable<boolean>,
32-
@IConfigurationService public readonly configurationService: IConfigurationService,
34+
@IConfigurationService private readonly configurationService: IConfigurationService,
35+
@INotificationService private readonly notificationService: INotificationService
3336
) {
3437
super();
3538

@@ -220,6 +223,7 @@ export class MergeEditorViewModel extends Disposable {
220223
public toggleActiveConflict(inputNumber: 1 | 2): void {
221224
const activeModifiedBaseRange = this.activeModifiedBaseRange.get();
222225
if (!activeModifiedBaseRange) {
226+
this.notificationService.error(localize('noConflictMessage', "There is currently no conflict focused that can be toggled."));
223227
return;
224228
}
225229
transaction(tx => {

0 commit comments

Comments
 (0)