joh/foreign cod (microsoft#182747)

* add more description to IE setting

* remove unused code

* 💄

Author: jrieken

src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorLivePreviewWidget.ts

@@ -128,10 +128,6 @@ export class InteractiveEditorLivePreviewWidget extends ZoneWidget {
 	}
 
 	override show(): void {
-		throw new Error('not supported like this, use showDiff');
-	}
-
-	showDiff(): void {
 		assertType(this.editor.hasModel());
 		this._updateFromChanges(this._session.wholeRange, this._session.lastTextModelChanges);
 		this._isVisible = true;

src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorStrategies.ts

@@ -364,7 +364,7 @@ export class LivePreviewStrategy extends LiveStrategy {
 
 	override async renderChanges(response: EditResponse) {
 
-		this._diffZone.showDiff();
+		this._diffZone.show();
 		this._updateSummaryMessage();
 		this._ctxShowingDiff.set(true);
 
@@ -382,7 +382,7 @@ export class LivePreviewStrategy extends LiveStrategy {
 			this._diffZone.hide();
 			this._ctxShowingDiff.set(false);
 		} else {
-			this._diffZone.showDiff();
+			this._diffZone.show();
 			this._ctxShowingDiff.set(true);
 		}
 		scrollState.restore(this._editor);

src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorWidget.ts

@@ -143,7 +143,7 @@ export class InteractiveEditorWidget {
 	private readonly _store = new DisposableStore();
 	private readonly _slashCommands = this._store.add(new DisposableStore());
 
-	readonly _inputEditor: IActiveCodeEditor;
+	private readonly _inputEditor: IActiveCodeEditor;
 	private readonly _inputModel: ITextModel;
 	private readonly _ctxInputEmpty: IContextKey<boolean>;
 	private readonly _ctxMessageCropState: IContextKey<'cropped' | 'not_cropped' | 'expanded'>;
@@ -662,17 +662,6 @@ export class InteractiveEditorZoneWidget extends ZoneWidget {
 		this._ctxVisible.set(true);
 	}
 
-	updatePosition(where: IPosition) {
-		// todo@jrieken
-		// UGYLY: we need to restore focus because showing the zone removes and adds it and that
-		// means we loose focus for a bit
-		const hasFocusNow = this.widget._inputEditor.hasWidgetFocus();
-		super.show(where, this._computeHeightInLines());
-		if (hasFocusNow) {
-			this.widget._inputEditor.focus();
-		}
-	}
-
 	protected override revealRange(_range: Range, _isLastLine: boolean) {
 		// disabled
 	}

src/vs/workbench/contrib/interactiveEditor/common/interactiveEditor.ts

@@ -158,10 +158,15 @@ Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfigurat
 	id: 'editor',
 	properties: {
 		'interactiveEditor.editMode': {
-			description: localize('editMode', "Configure if changes crafted in the interactive editor are applied directly or previewed first"),
+			description: localize('editMode', "Configure if changes crafted in the interactive editor are applied directly to the document or are previewed first."),
 			default: EditMode.LivePreview,
 			type: 'string',
-			enum: [EditMode.LivePreview, EditMode.Preview, EditMode.Live]
+			enum: [EditMode.LivePreview, EditMode.Preview, EditMode.Live],
+			markdownEnumDescriptions: [
+				localize('editMode.livePreview', "Changes are applied directly to the document and are highlighted visually via inline or side-by-side diffs. Ending a session will keep the changes."),
+				localize('editMode.preview', "Changes are previewed only and need to be accepted via the apply button. Ending a session will discard the changes."),
+				localize('editMode.live', "Changes are applied directly to the document but can be highlighted via inline diffs. Ending a session will keep the changes."),
+			]
 		}
 	}
 });