Refactor symbol replacement logic in TerminalSpeechToTextSession

meganrogge · meganrogge · commit 74f9854bca7d · 2024-01-17T20:12:27.000-08:00
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalSpeechToText.ts b/src/vs/workbench/contrib/terminal/browser/terminalSpeechToText.ts
@@ -140,10 +140,8 @@ export class TerminalSpeechToTextSession extends Disposable {
 	private _updateInput(e: ISpeechToTextEvent): void {
 		if (e.text) {
 			let input = e.text.replaceAll(/[.,?;!]/g, '');
-
-			for (const symbol of Object.values(symbolMap)) {
-				const regex: RegExp = new RegExp(symbol + '\b');
-				input = input.replace(regex, symbolMap[symbol]);
+			for (const symbol of Object.entries(symbolMap)) {
+				input = input.replace(new RegExp('\\b' + symbol[0] + '\\b'), symbol[1]);
 			}
 			this._input = ' ' + input;
 		}

Original file line number	Diff line number	Diff line change
`@@ -140,10 +140,8 @@ export class TerminalSpeechToTextSession extends Disposable {`
`140`	`140`	`private _updateInput(e: ISpeechToTextEvent): void {`
`141`	`141`	`if (e.text) {`
`142`	`142`	`let input = e.text.replaceAll(/[.,?;!]/g, '');`
`143`		`-`
`144`		`- for (const symbol of Object.values(symbolMap)) {`
`145`		`- const regex: RegExp = new RegExp(symbol + '\b');`
`146`		`- input = input.replace(regex, symbolMap[symbol]);`
	`143`	`+ for (const symbol of Object.entries(symbolMap)) {`
	`144`	`+ input = input.replace(new RegExp('\\b' + symbol[0] + '\\b'), symbol[1]);`
`147`	`145`	`}`
`148`	`146`	`this._input = ' ' + input;`
`149`	`147`	`}`