Merge pull request microsoft#201301 from microsoft/tyriar/200409_2

Tyriar · web-flow · commit 75b1639461b5 · 2023-12-20T06:18:09.000-08:00
Fix NPE in suggest
diff --git a/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminal.suggest.contribution.ts b/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminal.suggest.contribution.ts
@@ -44,7 +44,7 @@ class TerminalSuggestContribution extends DisposableStore implements ITerminalCo
 		this._terminalSuggestWidgetVisibleContextKey = TerminalContextKeys.suggestWidgetVisible.bindTo(this._contextKeyService);
 	}
 
-	xtermReady(xterm: IXtermTerminal & { raw: RawXtermTerminal }): void {
+	xtermOpen(xterm: IXtermTerminal & { raw: RawXtermTerminal }): void {
 		this._loadSuggestAddon(xterm.raw);
 		this.add(this._contextKeyService.onDidChangeContext(e => {
 			if (e.affectsSome(this._terminalSuggestWidgetContextKeys)) {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ class TerminalSuggestContribution extends DisposableStore implements ITerminalCo`
`44`	`44`	`this._terminalSuggestWidgetVisibleContextKey = TerminalContextKeys.suggestWidgetVisible.bindTo(this._contextKeyService);`
`45`	`45`	`}`
`46`	`46`
`47`		`- xtermReady(xterm: IXtermTerminal & { raw: RawXtermTerminal }): void {`
	`47`	`+ xtermOpen(xterm: IXtermTerminal & { raw: RawXtermTerminal }): void {`
`48`	`48`	`this._loadSuggestAddon(xterm.raw);`
`49`	`49`	`this.add(this._contextKeyService.onDidChangeContext(e => {`
`50`	`50`	`if (e.affectsSome(this._terminalSuggestWidgetContextKeys)) {`