Skip to content

Commit 75e7513

Browse files
authored
ChatRequestHandler should allow returning void (microsoft#208349)
Fix microsoft#205835
1 parent 20e7708 commit 75e7513

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

extensions/vscode-api-tests/src/singlefolder-tests/chat.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ suite('chat', () => {
4242

4343
const participant = chat.createChatParticipant('api-test.participant', (request, context, _progress, _token) => {
4444
emitter.fire({ request, context });
45-
return null;
4645
});
4746
participant.isDefault = true;
4847
disposables.push(participant);

src/vs/workbench/api/common/extHostChatAgents2.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ class ExtHostChatAgent {
620620
} satisfies vscode.ChatParticipant;
621621
}
622622

623-
invoke(request: vscode.ChatRequest, context: vscode.ChatContext, response: vscode.ChatExtendedResponseStream, token: CancellationToken): vscode.ProviderResult<vscode.ChatResult> {
623+
invoke(request: vscode.ChatRequest, context: vscode.ChatContext, response: vscode.ChatExtendedResponseStream, token: CancellationToken): vscode.ProviderResult<vscode.ChatResult | void> {
624624
return this._requestHandler(request, context, response, token);
625625
}
626626
}

src/vscode-dts/vscode.proposed.chatParticipant.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ declare module 'vscode' {
184184
/**
185185
* A chat request handler is a callback that will be invoked when a request is made to a chat participant.
186186
*/
187-
export type ChatRequestHandler = (request: ChatRequest, context: ChatContext, response: ChatResponseStream, token: CancellationToken) => ProviderResult<ChatResult>;
187+
export type ChatRequestHandler = (request: ChatRequest, context: ChatContext, response: ChatResponseStream, token: CancellationToken) => ProviderResult<ChatResult | void>;
188188

189189
/**
190190
* A chat participant can be invoked by the user in a chat session, using the `@` prefix. When it is invoked, it handles the chat request and is solely

src/vscode-dts/vscode.proposed.chatParticipantAdditions.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ declare module 'vscode' {
167167
constructor(label: string | CompletionItemLabel, values: ChatVariableValue[]);
168168
}
169169

170-
export type ChatExtendedRequestHandler = (request: ChatRequest, context: ChatContext, response: ChatExtendedResponseStream, token: CancellationToken) => ProviderResult<ChatResult>;
170+
export type ChatExtendedRequestHandler = (request: ChatRequest, context: ChatContext, response: ChatExtendedResponseStream, token: CancellationToken) => ProviderResult<ChatResult | void>;
171171

172172
export namespace chat {
173173
/**

0 commit comments

Comments
 (0)