Skip to content

Commit 75f4d52

Browse files
authored
update comments for telemetry events (microsoft#155525)
1 parent 6f8150c commit 75f4d52

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

src/vs/workbench/browser/parts/activitybar/activitybarActions.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ export class ViewContainerActivityAction extends ActivityAction {
103103
private logAction(action: string) {
104104
type ActivityBarActionClassification = {
105105
owner: 'sbatten';
106-
viewletId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
107-
action: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
106+
comment: 'Event logged when an activity bar action is triggered.';
107+
viewletId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The view in the activity bar for which the action was performed.' };
108+
action: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The action that was performed. e.g. "hide", "show", or "refocus"' };
108109
};
109110
this.telemetryService.publicLog2<{ viewletId: String; action: String }, ActivityBarActionClassification>('activityBarAction', { viewletId: this.activity.id, action });
110111
}

src/vs/workbench/contrib/experiments/common/experimentService.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,8 @@ export class ExperimentService extends Disposable implements IExperimentService
307307
return Promise.all(promises).then(() => {
308308
type ExperimentsClassification = {
309309
owner: 'sbatten';
310-
experiments: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };
310+
comment: 'Information about the experiments in this session';
311+
experiments: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The list of experiments in this session' };
311312
};
312313
this.telemetryService.publicLog2<{ experiments: string[] }, ExperimentsClassification>('experiments', { experiments: this._experiments.map(e => e.id) });
313314
});

src/vs/workbench/contrib/tags/electron-sandbox/workspaceTags.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export class WorkspaceTags implements IWorkbenchContribution {
6767
value = 'Unknown';
6868
}
6969

70-
this.telemetryService.publicLog2<{ edition: string }, { owner: 'sbatten'; edition: { classification: 'SystemMetaData'; purpose: 'BusinessInsight' } }>('windowsEdition', { edition: value });
70+
this.telemetryService.publicLog2<{ edition: string }, { owner: 'sbatten'; comment: 'Information about the Windows edition.'; edition: { classification: 'SystemMetaData'; purpose: 'BusinessInsight'; comment: 'The Windows edition.' } }>('windowsEdition', { edition: value });
7171
}
7272

7373
private async getWorkspaceInformation(): Promise<IWorkspaceInformation> {

0 commit comments

Comments
 (0)