Skip to content

Commit 773af96

Browse files
authored
remote: fix port forwarding not working (microsoft#182980)
fix: register a remote socket factory in the shared process Surprised this didn't fail more verbosely... Fixes microsoft#182749
1 parent 655f127 commit 773af96

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/vs/code/node/sharedProcess/sharedProcessMain.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,9 @@ import { UserDataAutoSyncService } from 'vs/platform/userDataSync/node/userDataA
109109
import { ExtensionTipsService } from 'vs/platform/extensionManagement/node/extensionTipsService';
110110
import { IMainProcessService, MainProcessService } from 'vs/platform/ipc/common/mainProcessService';
111111
import { RemoteStorageService } from 'vs/platform/storage/common/storageService';
112+
import { IRemoteSocketFactoryService, RemoteSocketFactoryService } from 'vs/platform/remote/common/remoteSocketFactoryService';
113+
import { RemoteConnectionType } from 'vs/platform/remote/common/remoteAuthorityResolver';
114+
import { nodeSocketFactory } from 'vs/platform/remote/node/nodeSocketFactory';
112115

113116
class SharedProcessMain extends Disposable {
114117

@@ -338,6 +341,9 @@ class SharedProcessMain extends Disposable {
338341
services.set(ISignService, new SyncDescriptor(SignService, undefined, false /* proxied to other processes */));
339342

340343
// Tunnel
344+
const remoteSocketFactoryService = new RemoteSocketFactoryService();
345+
services.set(IRemoteSocketFactoryService, remoteSocketFactoryService);
346+
remoteSocketFactoryService.register(RemoteConnectionType.WebSocket, nodeSocketFactory);
341347
services.set(ISharedTunnelsService, new SyncDescriptor(SharedTunnelsService));
342348
services.set(ISharedProcessTunnelService, new SyncDescriptor(SharedProcessTunnelService));
343349

0 commit comments

Comments
 (0)