testing: fix vertical centering of component in the call stack view (microsoft#227155)

connor4312 · web-flow · commit 777c2ac861af · 2024-08-29T23:31:12.000+02:00
![](https://memes.peet.io/img/24-08-4e5018a2-76fe-424b-afbe-a107f119d811.png)
diff --git a/src/vs/workbench/contrib/debug/browser/callStackWidget.ts b/src/vs/workbench/contrib/debug/browser/callStackWidget.ts
@@ -144,6 +144,7 @@ export class CallStackWidget extends Disposable {
 				multipleSelectionSupport: false,
 				mouseSupport: false,
 				keyboardSupport: false,
+				setRowLineHeight: false,
 				accessibilityProvider: instantiationService.createInstance(StackAccessibilityProvider),
 			}
 		) as WorkbenchList<ListItem>);
diff --git a/src/vs/workbench/contrib/debug/browser/media/callStackWidget.css b/src/vs/workbench/contrib/debug/browser/media/callStackWidget.css
@@ -24,6 +24,10 @@
 		&[role="link"] {
 			cursor: pointer;
 		}
+
+		.monaco-icon-label::before {
+			height: auto;
+		}
 	}
 
 	&.collapsed {
@@ -39,6 +43,7 @@
 	.collapse-button {
 		width: 16px;
 		min-height: 1px; /* show even if empty */
+		line-height: 0;
 
 		a {
 			cursor: pointer;
@@ -56,7 +61,6 @@
 .multiCallStackWidget {
 	.multiCallStackFrameContainer {
 		background: none !important;
-		line-height: inherit !important;
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,7 @@ export class CallStackWidget extends Disposable {`
`144`	`144`	`multipleSelectionSupport: false,`
`145`	`145`	`mouseSupport: false,`
`146`	`146`	`keyboardSupport: false,`
	`147`	`+ setRowLineHeight: false,`
`147`	`148`	`accessibilityProvider: instantiationService.createInstance(StackAccessibilityProvider),`
`148`	`149`	`}`
`149`	`150`	`) as WorkbenchList<ListItem>);`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,10 @@`
`24`	`24`	`&[role="link"] {`
`25`	`25`	`cursor: pointer;`
`26`	`26`	`}`
	`27`	`+`
	`28`	`+ .monaco-icon-label::before {`
	`29`	`+ height: auto;`
	`30`	`+ }`
`27`	`31`	`}`
`28`	`32`
`29`	`33`	`&.collapsed {`
`@@ -39,6 +43,7 @@`
`39`	`43`	`.collapse-button {`
`40`	`44`	`width: 16px;`
`41`	`45`	`min-height: 1px; /* show even if empty */`
	`46`	`+ line-height: 0;`
`42`	`47`
`43`	`48`	`a {`
`44`	`49`	`cursor: pointer;`
`@@ -56,7 +61,6 @@`
`56`	`61`	`.multiCallStackWidget {`
`57`	`62`	`.multiCallStackFrameContainer {`
`58`	`63`	`background: none !important;`
`59`		`- line-height: inherit !important;`
`60`	`64`	`}`
`61`	`65`	`}`
`62`	`66`