Skip to content

Commit 7830ea6

Browse files
authored
[Backport] Fix built-in walkthroughs rendering (microsoft#179335)
Fix built-in walkthroughs rendering
1 parent 7874d47 commit 7830ea6

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ export class GettingStartedPage extends EditorPane {
242242
}
243243
}));
244244

245+
this._register(this.gettingStartedService.onDidAddBuiltInWalkthrough(rerender));
245246
this._register(this.gettingStartedService.onDidAddWalkthrough(rerender));
246247
this._register(this.gettingStartedService.onDidRemoveWalkthrough(rerender));
247248

src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedService.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export interface IWalkthroughsService {
9797
readonly onDidRemoveWalkthrough: Event<string>;
9898
readonly onDidChangeWalkthrough: Event<IResolvedWalkthrough>;
9999
readonly onDidProgressStep: Event<IResolvedWalkthroughStep>;
100+
readonly onDidAddBuiltInWalkthrough: Event<void>;
100101

101102
readonly installedExtensionsRegistered: Promise<void>;
102103

@@ -134,6 +135,9 @@ export class WalkthroughsService extends Disposable implements IWalkthroughsServ
134135
private readonly _onDidProgressStep = new Emitter<IResolvedWalkthroughStep>();
135136
readonly onDidProgressStep: Event<IResolvedWalkthroughStep> = this._onDidProgressStep.event;
136137

138+
private readonly _onDidAddBuiltInWalkthrough = new Emitter<void>();
139+
readonly onDidAddBuiltInWalkthrough: Event<void> = this._onDidAddBuiltInWalkthrough.event;
140+
137141
private memento: Memento;
138142
private stepProgress: Record<string, StepProgress | undefined>;
139143

@@ -255,6 +259,8 @@ export class WalkthroughsService extends Disposable implements IWalkthroughsServ
255259
})
256260
});
257261
});
262+
263+
this._onDidAddBuiltInWalkthrough.fire();
258264
}
259265

260266
private updateWalkthroughContent(walkthrough: BuiltinGettingStartedCategory, experimentTreatment: WalkthroughTreatment): BuiltinGettingStartedCategory {

0 commit comments

Comments
 (0)