Close the terminal view when there's only one visible view

Tyriar · Tyriar · commit 78cd9519c5c7 · 2024-12-20T05:10:57.000-08:00
Part of microsoft#236517
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalGroupService.ts b/src/vs/workbench/contrib/terminal/browser/terminalGroupService.ts
@@ -83,7 +83,7 @@ export class TerminalGroupService extends Disposable implements ITerminalGroupSe
 	hidePanel(): void {
 		// Hide the panel if the terminal is in the panel and it has no sibling views
 		const panel = this._viewDescriptorService.getViewContainerByViewId(TERMINAL_VIEW_ID);
-		if (panel && this._viewDescriptorService.getViewContainerModel(panel).activeViewDescriptors.length === 1) {
+		if (panel && this._viewDescriptorService.getViewContainerModel(panel).visibleViewDescriptors.length === 1) {
 			this._viewsService.closeView(TERMINAL_VIEW_ID);
 			TerminalContextKeys.tabsMouse.bindTo(this._contextKeyService).set(false);
 		}

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ export class TerminalGroupService extends Disposable implements ITerminalGroupSe`
`83`	`83`	`hidePanel(): void {`
`84`	`84`	`// Hide the panel if the terminal is in the panel and it has no sibling views`
`85`	`85`	`const panel = this._viewDescriptorService.getViewContainerByViewId(TERMINAL_VIEW_ID);`
`86`		`- if (panel && this._viewDescriptorService.getViewContainerModel(panel).activeViewDescriptors.length === 1) {`
	`86`	`+ if (panel && this._viewDescriptorService.getViewContainerModel(panel).visibleViewDescriptors.length === 1) {`
`87`	`87`	`this._viewsService.closeView(TERMINAL_VIEW_ID);`
`88`	`88`	`TerminalContextKeys.tabsMouse.bindTo(this._contextKeyService).set(false);`
`89`	`89`	`}`