Protect against empty readonly-message (microsoft#203328)

alexr00 · web-flow · commit 7970376dda21 · 2024-01-24T13:08:41.000+01:00
Fixes microsoft#203122
diff --git a/src/vs/workbench/api/common/extHostFileSystem.ts b/src/vs/workbench/api/common/extHostFileSystem.ts
@@ -166,7 +166,7 @@ export class ExtHostFileSystem implements ExtHostFileSystemShape {
 		}
 
 		let readOnlyMessage: IMarkdownString | undefined;
-		if (options.isReadonly && isMarkdownString(options.isReadonly)) {
+		if (options.isReadonly && isMarkdownString(options.isReadonly) && options.isReadonly.value !== '') {
 			readOnlyMessage = {
 				value: options.isReadonly.value,
 				isTrusted: options.isReadonly.isTrusted,

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ export class ExtHostFileSystem implements ExtHostFileSystemShape {`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`let readOnlyMessage: IMarkdownString \| undefined;`
`169`		`- if (options.isReadonly && isMarkdownString(options.isReadonly)) {`
	`169`	`+ if (options.isReadonly && isMarkdownString(options.isReadonly) && options.isReadonly.value !== '') {`
`170`	`170`	`readOnlyMessage = {`
`171`	`171`	`value: options.isReadonly.value,`
`172`	`172`	`isTrusted: options.isReadonly.isTrusted,`