Register with editorResolver before attempting to open walkthrough (microsoft#184969)

bhavyaus · web-flow · commit 79c4092768e4 · 2023-06-13T03:38:34.000+02:00
diff --git a/src/vs/workbench/contrib/welcomeGettingStarted/browser/startupPage.ts b/src/vs/workbench/contrib/welcomeGettingStarted/browser/startupPage.ts
@@ -55,8 +55,6 @@ export class StartupPageContribution implements IWorkbenchContribution {
 		@INotificationService private readonly notificationService: INotificationService,
 		@IEditorResolverService editorResolverService: IEditorResolverService
 	) {
-		this.run().then(undefined, onUnexpectedError);
-
 		editorResolverService.registerEditor(
 			`${GettingStartedInput.RESOURCE.scheme}:/**`,
 			{
@@ -80,6 +78,8 @@ export class StartupPageContribution implements IWorkbenchContribution {
 				}
 			}
 		);
+
+		this.run().then(undefined, onUnexpectedError);
 	}
 
 	private async run() {

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,6 @@ export class StartupPageContribution implements IWorkbenchContribution {`
`55`	`55`	`@INotificationService private readonly notificationService: INotificationService,`
`56`	`56`	`@IEditorResolverService editorResolverService: IEditorResolverService`
`57`	`57`	`) {`
`58`		`- this.run().then(undefined, onUnexpectedError);`
`59`		`-`
`60`	`58`	`editorResolverService.registerEditor(`
`61`	`59`	`${GettingStartedInput.RESOURCE.scheme}:/**`,
`62`	`60`	`{`
`@@ -80,6 +78,8 @@ export class StartupPageContribution implements IWorkbenchContribution {`
`80`	`78`	`}`
`81`	`79`	`}`
`82`	`80`	`);`
	`81`	`+`
	`82`	`+ this.run().then(undefined, onUnexpectedError);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`private async run() {`